pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Use return instead of exit() in configure 6+ messages / 3 participants [nested] [flat]
* pgsql: Use return instead of exit() in configure @ 2016-09-30 18:11 Peter Eisentraut <peter_e@gmx.net> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2016-09-30 18:11 UTC (permalink / raw) To: pgsql-committers Use return instead of exit() in configure Using exit() requires stdlib.h, which is not included. Use return instead. Also add return type for main(). Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Reviewed-by: Thomas Munro <thomas.munro@enterprisedb.com> Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/1c0cf52b39ca3a9a79661129cff918dc000a55eb Modified Files -------------- config/c-compiler.m4 | 4 +++- config/c-library.m4 | 4 +++- configure | 12 +++++++++--- 3 files changed, 15 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Use return instead of exit() in configure @ 2020-09-08 08:11 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2020-09-08 08:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use return instead of exit() in configure Using exit() requires stdlib.h, which is not included. Use return instead. Also add return type for main(). Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Reviewed-by: Thomas Munro <thomas.munro@enterprisedb.com> Backpatched because Apple macOS 10.16/11 (Big Sur) compiler makes calling undeclared functions an error, so these configure tests would fail. Reported-by: Thomas Gilligan <thomas.gilligan@icloud.com> Reported-by: Jesse Zhang <sbjesse@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/09A4B554-82B1-4536-B191-2461342EE0BB%40icloud.com Branch ------ REL9_5_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/69fdf3d2e987cb5543f00a945cffbf6e422d5868 Modified Files -------------- config/c-compiler.m4 | 4 +++- config/c-library.m4 | 4 +++- configure | 12 +++++++++--- 3 files changed, 15 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Use return instead of exit() in configure @ 2020-09-08 08:11 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2020-09-08 08:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use return instead of exit() in configure Using exit() requires stdlib.h, which is not included. Use return instead. Also add return type for main(). Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Reviewed-by: Thomas Munro <thomas.munro@enterprisedb.com> Backpatched because Apple macOS 10.16/11 (Big Sur) compiler makes calling undeclared functions an error, so these configure tests would fail. Reported-by: Thomas Gilligan <thomas.gilligan@icloud.com> Reported-by: Jesse Zhang <sbjesse@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/09A4B554-82B1-4536-B191-2461342EE0BB%40icloud.com Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/27acbd51e60c98cba6441d7a88210a1c33bf9db4 Modified Files -------------- config/c-compiler.m4 | 4 +++- config/c-library.m4 | 4 +++- configure | 12 +++++++++--- 3 files changed, 15 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Use return instead of exit() in configure @ 2021-12-12 19:54 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-12-12 19:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use return instead of exit() in configure Using exit() requires stdlib.h, which is not included. Use return instead. Also add return type for main(). This back-patches commit 1c0cf52b3 into out-of-support branches, pursuant to a newly-established project policy that we'll try to keep out-of-support branches buildable on modern platforms for at least ten major releases back, ensuring people can test pg_dump and psql compatibility against servers that far back. With the current development branch being v15, that works out to keeping 9.2 and up buildable as of today. This fix is needed to get through 'configure' when using recent macOS (and possibly other clang-based toolchains). It seems to be sufficient to get through 'check-world', although there are annoyances such as compiler warnings, which will be dealt with separately. Original patch by Peter Eisentraut Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com Branch ------ REL9_2_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fed9cf2cb9ef4cdc3fe8b09dc2eb19e82fe1cc8b Modified Files -------------- config/c-compiler.m4 | 4 +++- config/c-library.m4 | 4 +++- configure | 12 +++++++++--- 3 files changed, 15 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Use return instead of exit() in configure @ 2021-12-12 19:54 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-12-12 19:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use return instead of exit() in configure Using exit() requires stdlib.h, which is not included. Use return instead. Also add return type for main(). This back-patches commit 1c0cf52b3 into out-of-support branches, pursuant to a newly-established project policy that we'll try to keep out-of-support branches buildable on modern platforms for at least ten major releases back, ensuring people can test pg_dump and psql compatibility against servers that far back. With the current development branch being v15, that works out to keeping 9.2 and up buildable as of today. This fix is needed to get through 'configure' when using recent macOS (and possibly other clang-based toolchains). It seems to be sufficient to get through 'check-world', although there are annoyances such as compiler warnings, which will be dealt with separately. Original patch by Peter Eisentraut Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com Branch ------ REL9_3_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f24374bce687a2279f9befd3a1da72bd9ca7d1bd Modified Files -------------- config/c-compiler.m4 | 4 +++- config/c-library.m4 | 4 +++- configure | 12 +++++++++--- 3 files changed, 15 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Use return instead of exit() in configure @ 2021-12-12 19:54 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-12-12 19:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use return instead of exit() in configure Using exit() requires stdlib.h, which is not included. Use return instead. Also add return type for main(). This back-patches commit 1c0cf52b3 into out-of-support branches, pursuant to a newly-established project policy that we'll try to keep out-of-support branches buildable on modern platforms for at least ten major releases back, ensuring people can test pg_dump and psql compatibility against servers that far back. With the current development branch being v15, that works out to keeping 9.2 and up buildable as of today. This fix is needed to get through 'configure' when using recent macOS (and possibly other clang-based toolchains). It seems to be sufficient to get through 'check-world', although there are annoyances such as compiler warnings, which will be dealt with separately. Original patch by Peter Eisentraut Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com Branch ------ REL9_4_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/47fca011b88a9c0eadf2b62f6c1943deae0631c3 Modified Files -------------- config/c-compiler.m4 | 4 +++- config/c-library.m4 | 4 +++- configure | 12 +++++++++--- 3 files changed, 15 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2021-12-12 19:54 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2016-09-30 18:11 pgsql: Use return instead of exit() in configure Peter Eisentraut <peter_e@gmx.net> 2020-09-08 08:11 pgsql: Use return instead of exit() in configure Peter Eisentraut <peter@eisentraut.org> 2020-09-08 08:11 pgsql: Use return instead of exit() in configure Peter Eisentraut <peter@eisentraut.org> 2021-12-12 19:54 pgsql: Use return instead of exit() in configure Tom Lane <tgl@sss.pgh.pa.us> 2021-12-12 19:54 pgsql: Use return instead of exit() in configure Tom Lane <tgl@sss.pgh.pa.us> 2021-12-12 19:54 pgsql: Use return instead of exit() in configure Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox