pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use return instead of exit() in configure
Date: Tue, 08 Sep 2020 08:11:18 +0000
Message-ID: <E1kFYik-0000IP-FB@gemulon.postgresql.org> (raw)

Use return instead of exit() in configure

Using exit() requires stdlib.h, which is not included.  Use return
instead.  Also add return type for main().

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Thomas Munro <thomas.munro@enterprisedb.com>

Backpatched because Apple macOS 10.16/11 (Big Sur) compiler makes
calling undeclared functions an error, so these configure tests would
fail.

Reported-by: Thomas Gilligan <thomas.gilligan@icloud.com>
Reported-by: Jesse Zhang <sbjesse@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/09A4B554-82B1-4536-B191-2461342EE0BB%40icloud.com

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/27acbd51e60c98cba6441d7a88210a1c33bf9db4

Modified Files
--------------
config/c-compiler.m4 |  4 +++-
config/c-library.m4  |  4 +++-
configure            | 12 +++++++++---
3 files changed, 15 insertions(+), 5 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1kFYik-0000IP-FB@gemulon.postgresql.org>
Permalink:  ../E1kFYik-0000IP-FB@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1kFYik-0000IP-FB@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Use return instead of exit() in configure
  In-Reply-To: <E1kFYik-0000IP-FB@gemulon.postgresql.org>
  References: <E1kFYik-0000IP-FB@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox