pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix incorrect format placeholder
19+ messages / 3 participants
[nested] [flat]
* pgsql: Fix incorrect format placeholder
@ 2021-04-23 05:24 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 19+ messages in thread
From: Peter Eisentraut @ 2021-04-23 05:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7776a23a4bdeb7215e4f8ddea5989cb143becc12
Modified Files
--------------
src/backend/utils/misc/guc-file.l | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
* pgsql: Fix incorrect format placeholder
@ 2021-09-29 06:19 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 19+ messages in thread
From: Peter Eisentraut @ 2021-09-29 06:19 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0b947c3101d1d05c55531731d6b778f82cb21350
Modified Files
--------------
src/include/lib/simplehash.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
* pgsql: Fix incorrect format placeholder
@ 2021-10-13 06:23 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 19+ messages in thread
From: Peter Eisentraut @ 2021-10-13 06:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/780054bf31a0a6ba781f46c454f0116efee8a74c
Modified Files
--------------
src/bin/pgbench/pgbench.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
* pgsql: Fix incorrect format placeholder
@ 2021-11-03 06:38 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 19+ messages in thread
From: Peter Eisentraut @ 2021-11-03 06:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ef6f047d2c87b91318364341c058dd6b715951b2
Modified Files
--------------
src/bin/initdb/initdb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
* pgsql: Fix incorrect format placeholder.
@ 2021-11-08 19:32 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 19+ messages in thread
From: Tom Lane @ 2021-11-08 19:32 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder.
Per buildfarm warnings.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b0cf5444f9a8d915b2e9b44790025f17a7dc107f
Modified Files
--------------
src/bin/pg_basebackup/pg_receivewal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: pgsql: Fix incorrect format placeholder.
@ 2021-11-09 01:54 Michael Paquier <michael@paquier.xyz>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 19+ messages in thread
From: Michael Paquier @ 2021-11-09 01:54 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On Mon, Nov 08, 2021 at 07:32:41PM +0000, Tom Lane wrote:
> Fix incorrect format placeholder.
>
> Per buildfarm warnings.
Thanks, that's embarassing. The last time I bumped into this issue,
the report came from lapwing which would directly report a failure,
but it did not happen this time. Which animal has reported that?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: pgsql: Fix incorrect format placeholder.
@ 2021-11-09 05:19 Tom Lane <tgl@sss.pgh.pa.us>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 19+ messages in thread
From: Tom Lane @ 2021-11-09 05:19 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
Michael Paquier <michael@paquier.xyz> writes:
> Thanks, that's embarassing. The last time I bumped into this issue,
> the report came from lapwing which would directly report a failure,
> but it did not happen this time. Which animal has reported that?
Umm ... florican and dangomushi spotted it. Maybe we need a 32-bit
machine with -Werror?
regards, tom lane
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: pgsql: Fix incorrect format placeholder.
@ 2021-11-09 05:38 Michael Paquier <michael@paquier.xyz>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 19+ messages in thread
From: Michael Paquier @ 2021-11-09 05:38 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Nov 09, 2021 at 12:19:36AM -0500, Tom Lane wrote:
> Umm ... florican and dangomushi spotted it. Maybe we need a 32-bit
> machine with -Werror?
Indeed, I can see it in the logs of dangomushi. I could add a -Werror
there, but there are also a bunch of warnings generated by plperl.
I'd rather keep --with-perl and clang, and there seems to be a fix
regarding that stuff in upstream:
https://www.nntp.perl.org/group/perl.perl5.changes/2021/07/msg57758.html
But it also looks like Archlinux ARM did not catch up that yet..
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: pgsql: Fix incorrect format placeholder.
@ 2021-11-09 06:06 Tom Lane <tgl@sss.pgh.pa.us>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 19+ messages in thread
From: Tom Lane @ 2021-11-09 06:06 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Nov 09, 2021 at 12:19:36AM -0500, Tom Lane wrote:
>> Umm ... florican and dangomushi spotted it. Maybe we need a 32-bit
>> machine with -Werror?
> Indeed, I can see it in the logs of dangomushi. I could add a -Werror
> there, but there are also a bunch of warnings generated by plperl.
Yeah, we had complaints before about -Wcompound-token-split-by-macro
warnings.
> I'd rather keep --with-perl and clang, and there seems to be a fix
> regarding that stuff in upstream:
> https://www.nntp.perl.org/group/perl.perl5.changes/2021/07/msg57758.html
I figured the Perl guys would do something about it, but it will be a
very long time before that propagates everywhere. Maybe we should
teach configure to add -Wno-compound-token-split-by-macro? By my
count there are now five buildfarm members besides dangomushi that
are producing these warnings, and I think the number is going to
go up before it goes down.
(Meanwhile, I guess I could enable -Werror on florican.)
regards, tom lane
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: pgsql: Fix incorrect format placeholder.
@ 2021-11-09 11:16 Michael Paquier <michael@paquier.xyz>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 19+ messages in thread
From: Michael Paquier @ 2021-11-09 11:16 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Nov 09, 2021 at 01:06:26AM -0500, Tom Lane wrote:
> I figured the Perl guys would do something about it, but it will be a
> very long time before that propagates everywhere. Maybe we should
> teach configure to add -Wno-compound-token-split-by-macro? By my
> count there are now five buildfarm members besides dangomushi that
> are producing these warnings, and I think the number is going to
> go up before it goes down.
>
> (Meanwhile, I guess I could enable -Werror on florican.)
Yeah, you have a point here. -Wcompound-token-split-by-macro is new
as of clang-12 from last April, so I am a bit surprised that it is
that present in the buildfarm TBH.
The attached is sufficient to remove those warnings. Debian provides
clang-12, so it is easy to reproduce the problem.
What do you think?
--
Michael
Attachments:
plperl-clang-warnings.patch (text/x-diff, 2.9K) download
diff --git a/configure b/configure
index 4ffefe4655..6856ec649d 100755
--- a/configure
+++ b/configure
@@ -6334,6 +6334,52 @@ fi
if test -n "$NOT_THE_CFLAGS"; then
CFLAGS="$CFLAGS -Wno-unused-command-line-argument"
fi
+ # Remove clang 12+'s compound-token-split-by-macro, as this causes a lot
+ # of warnings when building plperl because of Perl. Like previously, test
+ # for the positive form and add the negative form
+ NOT_THE_CFLAGS=""
+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether ${CC} supports -Wcompound-token-split-by-macro, for NOT_THE_CFLAGS" >&5
+$as_echo_n "checking whether ${CC} supports -Wcompound-token-split-by-macro, for NOT_THE_CFLAGS... " >&6; }
+if ${pgac_cv_prog_CC_cflags__Wcompound_token_split_by_macro+:} false; then :
+ $as_echo_n "(cached) " >&6
+else
+ pgac_save_CFLAGS=$CFLAGS
+pgac_save_CC=$CC
+CC=${CC}
+CFLAGS="${NOT_THE_CFLAGS} -Wcompound-token-split-by-macro"
+ac_save_c_werror_flag=$ac_c_werror_flag
+ac_c_werror_flag=yes
+cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h. */
+
+int
+main ()
+{
+
+ ;
+ return 0;
+}
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+ pgac_cv_prog_CC_cflags__Wcompound_token_split_by_macro=yes
+else
+ pgac_cv_prog_CC_cflags__Wcompound_token_split_by_macro=no
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+ac_c_werror_flag=$ac_save_c_werror_flag
+CFLAGS="$pgac_save_CFLAGS"
+CC="$pgac_save_CC"
+fi
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $pgac_cv_prog_CC_cflags__Wcompound_token_split_by_macro" >&5
+$as_echo "$pgac_cv_prog_CC_cflags__Wcompound_token_split_by_macro" >&6; }
+if test x"$pgac_cv_prog_CC_cflags__Wcompound_token_split_by_macro" = x"yes"; then
+ NOT_THE_CFLAGS="${NOT_THE_CFLAGS} -Wcompound-token-split-by-macro"
+fi
+
+
+ if test -n "$NOT_THE_CFLAGS"; then
+ CFLAGS="$CFLAGS -Wno-compound-token-split-by-macro"
+ fi
# Similarly disable useless truncation warnings from gcc 8+
NOT_THE_CFLAGS=""
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether ${CC} supports -Wformat-truncation, for NOT_THE_CFLAGS" >&5
diff --git a/configure.ac b/configure.ac
index 44ee3ebe2f..05a00b3e14 100644
--- a/configure.ac
+++ b/configure.ac
@@ -530,6 +530,14 @@ if test "$GCC" = yes -a "$ICC" = no; then
if test -n "$NOT_THE_CFLAGS"; then
CFLAGS="$CFLAGS -Wno-unused-command-line-argument"
fi
+ # Remove clang 12+'s compound-token-split-by-macro, as this causes a lot
+ # of warnings when building plperl because of Perl. Like previously, test
+ # for the positive form and add the negative form
+ NOT_THE_CFLAGS=""
+ PGAC_PROG_CC_VAR_OPT(NOT_THE_CFLAGS, [-Wcompound-token-split-by-macro])
+ if test -n "$NOT_THE_CFLAGS"; then
+ CFLAGS="$CFLAGS -Wno-compound-token-split-by-macro"
+ fi
# Similarly disable useless truncation warnings from gcc 8+
NOT_THE_CFLAGS=""
PGAC_PROG_CC_VAR_OPT(NOT_THE_CFLAGS, [-Wformat-truncation])
* Re: pgsql: Fix incorrect format placeholder.
@ 2021-11-09 14:40 Tom Lane <tgl@sss.pgh.pa.us>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 19+ messages in thread
From: Tom Lane @ 2021-11-09 14:40 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
Michael Paquier <michael@paquier.xyz> writes:
> Yeah, you have a point here. -Wcompound-token-split-by-macro is new
> as of clang-12 from last April, so I am a bit surprised that it is
> that present in the buildfarm TBH.
> The attached is sufficient to remove those warnings. Debian provides
> clang-12, so it is easy to reproduce the problem.
OK by me, but probably should raise the issue in -hackers not just
-committers. Also, please back-patch once the release freeze lifts.
regards, tom lane
^ permalink raw reply [nested|flat] 19+ messages in thread
* Re: pgsql: Fix incorrect format placeholder.
@ 2021-11-09 22:26 Michael Paquier <michael@paquier.xyz>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 19+ messages in thread
From: Michael Paquier @ 2021-11-09 22:26 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Nov 09, 2021 at 09:40:47AM -0500, Tom Lane wrote:
> OK by me, but probably should raise the issue in -hackers not just
> -committers. Also, please back-patch once the release freeze lifts.
Sure.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 19+ messages in thread
* pgsql: Fix incorrect format placeholder
@ 2023-02-10 11:30 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 19+ messages in thread
From: Peter Eisentraut @ 2023-02-10 11:30 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f8ba1bf4e48369450cdc71b5bf12d8f7bdaf10f3
Modified Files
--------------
src/backend/parser/parse_relation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
* pgsql: Fix incorrect format placeholder
@ 2023-02-17 13:19 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 19+ messages in thread
From: Peter Eisentraut @ 2023-02-17 13:19 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/881a91781f49b6116ee6ce49b5bcc03da7200423
Modified Files
--------------
src/test/modules/test_slru/test_slru.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
* pgsql: Fix incorrect format placeholder
@ 2023-10-03 06:35 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 19+ messages in thread
From: Peter Eisentraut @ 2023-10-03 06:35 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/aea599cfc06b54426160a630e94ab7bdff7529c5
Modified Files
--------------
src/test/modules/libpq_pipeline/libpq_pipeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
* pgsql: Fix incorrect format placeholder
@ 2024-01-11 20:51 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 19+ messages in thread
From: Peter Eisentraut @ 2024-01-11 20:51 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/35bc310c04a477376778f437a56f0fcfb504c9c3
Modified Files
--------------
src/bin/pg_upgrade/info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
* pgsql: Fix incorrect format placeholder
@ 2024-02-26 06:36 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 19+ messages in thread
From: Peter Eisentraut @ 2024-02-26 06:36 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder
Not only did the format placeholder not match the variable, the
variable also didn't match the function it was getting its value from.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/025f0a6f9113efe89bb65b9efe0cb96a5d7c7ad1
Modified Files
--------------
src/backend/backup/basebackup_incremental.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
* pgsql: Fix incorrect format placeholder
@ 2024-05-08 06:43 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 19+ messages in thread
From: Peter Eisentraut @ 2024-05-08 06:43 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6d716adf8569b734eb8849094e9b3edab084c7f8
Modified Files
--------------
src/backend/replication/logical/slotsync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
* pgsql: Fix incorrect format placeholder
@ 2025-04-08 17:17 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 19+ messages in thread
From: Peter Eisentraut @ 2025-04-08 17:17 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix incorrect format placeholder
for commit 749a9e20c97
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8969194b73dbc9642a0302225f686f9febd95c90
Modified Files
--------------
contrib/pgcrypto/crypt-gensalt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 19+ messages in thread
end of thread, other threads:[~2025-04-08 17:17 UTC | newest]
Thread overview: 19+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 05:24 pgsql: Fix incorrect format placeholder Peter Eisentraut <peter@eisentraut.org>
2021-09-29 06:19 pgsql: Fix incorrect format placeholder Peter Eisentraut <peter@eisentraut.org>
2021-10-13 06:23 pgsql: Fix incorrect format placeholder Peter Eisentraut <peter@eisentraut.org>
2021-11-03 06:38 pgsql: Fix incorrect format placeholder Peter Eisentraut <peter@eisentraut.org>
2021-11-08 19:32 pgsql: Fix incorrect format placeholder. Tom Lane <tgl@sss.pgh.pa.us>
2021-11-09 01:54 ` Re: pgsql: Fix incorrect format placeholder. Michael Paquier <michael@paquier.xyz>
2021-11-09 05:19 ` Re: pgsql: Fix incorrect format placeholder. Tom Lane <tgl@sss.pgh.pa.us>
2021-11-09 05:38 ` Re: pgsql: Fix incorrect format placeholder. Michael Paquier <michael@paquier.xyz>
2021-11-09 06:06 ` Re: pgsql: Fix incorrect format placeholder. Tom Lane <tgl@sss.pgh.pa.us>
2021-11-09 11:16 ` Re: pgsql: Fix incorrect format placeholder. Michael Paquier <michael@paquier.xyz>
2021-11-09 14:40 ` Re: pgsql: Fix incorrect format placeholder. Tom Lane <tgl@sss.pgh.pa.us>
2021-11-09 22:26 ` Re: pgsql: Fix incorrect format placeholder. Michael Paquier <michael@paquier.xyz>
2023-02-10 11:30 pgsql: Fix incorrect format placeholder Peter Eisentraut <peter@eisentraut.org>
2023-02-17 13:19 pgsql: Fix incorrect format placeholder Peter Eisentraut <peter@eisentraut.org>
2023-10-03 06:35 pgsql: Fix incorrect format placeholder Peter Eisentraut <peter@eisentraut.org>
2024-01-11 20:51 pgsql: Fix incorrect format placeholder Peter Eisentraut <peter@eisentraut.org>
2024-02-26 06:36 pgsql: Fix incorrect format placeholder Peter Eisentraut <peter@eisentraut.org>
2024-05-08 06:43 pgsql: Fix incorrect format placeholder Peter Eisentraut <peter@eisentraut.org>
2025-04-08 17:17 pgsql: Fix incorrect format placeholder Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox