pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Add table to regression tests for binary-compatibility checks in
5+ messages / 1 participants
[nested] [flat]

Commits from this thread:
  2021-11-18 ac1c7458b1 048f3ee618 49f2b1168a 82bb97ed63  Fix quoting of ACL item in table for upgrade binary compatibility checks
* pgsql: Add table to regression tests for binary-compatibility checks in
@ 2021-11-18 01:38 Michael Paquier <michael@paquier.xyz>
  2021-11-18 02:19 ` Re: pgsql: Add table to regression tests for binary-compatibility checks in Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 5+ messages in thread

From: Michael Paquier @ 2021-11-18 01:38 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add table to regression tests for binary-compatibility checks in pg_upgrade

This commit adds to the main regression test suite a table with all
the in-core data types (some exceptions apply).  This table is not
dropped, so as pg_upgrade would be able to check the binary
compatibility of the types tracked in the table.  If a new type is added
in core, this part of the tests would need a refresh but the tests are
designed to fail if that were to happen.

As this is useful for upgrades and that these rely on the objects
created in the regression test suite of the old version upgraded from,
a backpatch down to 12 is done, which is the last point where a binary
incompatible change has been done (7c15cef).  This will hopefully be
enough to find out if something gets broken during the development of a
new version of Postgres, so as it is possible to take actions in
pg_upgrade itself in this case (like 0ccfc28 for sql_identifier).

An area that is not covered yet is related to external modules, which
may create their own types.  The testing infrastructure of pg_upgrade is
not integrated yet with the external modules stored in core
(src/test/modules/ or contrib/, all use the same database name for their
tests so there would be an overlap).  This could be improved in the
future.

Author: Justin Pryzby
Reviewed-by: Jacob Champion, Peter Eisentraut, Tom Lane, Michael Paquier
Discussion: https://postgr.es/m/20201206180248.GI24052@telsasoft.com
Backpatch-through: 12

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/835bcba8b8d72a00cecc5431b67e70bbea93f947

Modified Files
--------------
src/test/regress/expected/sanity_check.out |   1 +
src/test/regress/expected/type_sanity.out  | 102 +++++++++++++++++++++++++++++
src/test/regress/sql/type_sanity.sql       | 100 ++++++++++++++++++++++++++++
3 files changed, 203 insertions(+)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Add table to regression tests for binary-compatibility checks in
  2021-11-18 01:38 pgsql: Add table to regression tests for binary-compatibility checks in Michael Paquier <michael@paquier.xyz>
@ 2021-11-18 02:19 ` Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 5+ messages in thread

From: Michael Paquier @ 2021-11-18 02:19 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

On Thu, Nov 18, 2021 at 01:38:30AM +0000, Michael Paquier wrote:
> Add table to regression tests for binary-compatibility checks in pg_upgrade
> 
> This commit adds to the main regression test suite a table with all
> the in-core data types (some exceptions apply).  This table is not
> dropped, so as pg_upgrade would be able to check the binary
> compatibility of the types tracked in the table.  If a new type is added
> in core, this part of the tests would need a refresh but the tests are
> designed to fail if that were to happen.

prion has been failing in a fancy way:
   arraymultirange(arrayrange(ARRAY[1,2], ARRAY[2,1]));
+ERROR:  unrecognized key word: "ec2"
+HINT:  ACL key word must be "group" or "user".

That's an environment-related issue, as the user name of this animal
uses an hyphen "ec2-user", and this is bumping on the generation of
the aclitem.  This is missing some quote_ident()'s, visibly.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Add table to regression tests for binary-compatibility checks in
@ 2021-11-18 01:38 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 5+ messages in thread

From: Michael Paquier @ 2021-11-18 01:38 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add table to regression tests for binary-compatibility checks in pg_upgrade

This commit adds to the main regression test suite a table with all
the in-core data types (some exceptions apply).  This table is not
dropped, so as pg_upgrade would be able to check the binary
compatibility of the types tracked in the table.  If a new type is added
in core, this part of the tests would need a refresh but the tests are
designed to fail if that were to happen.

As this is useful for upgrades and that these rely on the objects
created in the regression test suite of the old version upgraded from,
a backpatch down to 12 is done, which is the last point where a binary
incompatible change has been done (7c15cef).  This will hopefully be
enough to find out if something gets broken during the development of a
new version of Postgres, so as it is possible to take actions in
pg_upgrade itself in this case (like 0ccfc28 for sql_identifier).

An area that is not covered yet is related to external modules, which
may create their own types.  The testing infrastructure of pg_upgrade is
not integrated yet with the external modules stored in core
(src/test/modules/ or contrib/, all use the same database name for their
tests so there would be an overlap).  This could be improved in the
future.

Author: Justin Pryzby
Reviewed-by: Jacob Champion, Peter Eisentraut, Tom Lane, Michael Paquier
Discussion: https://postgr.es/m/20201206180248.GI24052@telsasoft.com
Backpatch-through: 12

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cf3d79aa31f2acb11a03475c33e8e962dcb935a1

Modified Files
--------------
src/test/regress/expected/sanity_check.out |   1 +
src/test/regress/expected/type_sanity.out  | 102 +++++++++++++++++++++++++++++
src/test/regress/sql/type_sanity.sql       | 100 ++++++++++++++++++++++++++++
3 files changed, 203 insertions(+)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Add table to regression tests for binary-compatibility checks in
@ 2021-11-18 01:38 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 5+ messages in thread

From: Michael Paquier @ 2021-11-18 01:38 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add table to regression tests for binary-compatibility checks in pg_upgrade

This commit adds to the main regression test suite a table with all
the in-core data types (some exceptions apply).  This table is not
dropped, so as pg_upgrade would be able to check the binary
compatibility of the types tracked in the table.  If a new type is added
in core, this part of the tests would need a refresh but the tests are
designed to fail if that were to happen.

As this is useful for upgrades and that these rely on the objects
created in the regression test suite of the old version upgraded from,
a backpatch down to 12 is done, which is the last point where a binary
incompatible change has been done (7c15cef).  This will hopefully be
enough to find out if something gets broken during the development of a
new version of Postgres, so as it is possible to take actions in
pg_upgrade itself in this case (like 0ccfc28 for sql_identifier).

An area that is not covered yet is related to external modules, which
may create their own types.  The testing infrastructure of pg_upgrade is
not integrated yet with the external modules stored in core
(src/test/modules/ or contrib/, all use the same database name for their
tests so there would be an overlap).  This could be improved in the
future.

Author: Justin Pryzby
Reviewed-by: Jacob Champion, Peter Eisentraut, Tom Lane, Michael Paquier
Discussion: https://postgr.es/m/20201206180248.GI24052@telsasoft.com
Backpatch-through: 12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/755f04c72ef1bac5e34ab698aaf9d3a303ac5197

Modified Files
--------------
src/test/regress/expected/sanity_check.out |  1 +
src/test/regress/expected/type_sanity.out  | 97 ++++++++++++++++++++++++++++++
src/test/regress/sql/type_sanity.sql       | 95 +++++++++++++++++++++++++++++
3 files changed, 193 insertions(+)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Add table to regression tests for binary-compatibility checks in
@ 2021-11-18 01:38 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 5+ messages in thread

From: Michael Paquier @ 2021-11-18 01:38 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Add table to regression tests for binary-compatibility checks in pg_upgrade

This commit adds to the main regression test suite a table with all
the in-core data types (some exceptions apply).  This table is not
dropped, so as pg_upgrade would be able to check the binary
compatibility of the types tracked in the table.  If a new type is added
in core, this part of the tests would need a refresh but the tests are
designed to fail if that were to happen.

As this is useful for upgrades and that these rely on the objects
created in the regression test suite of the old version upgraded from,
a backpatch down to 12 is done, which is the last point where a binary
incompatible change has been done (7c15cef).  This will hopefully be
enough to find out if something gets broken during the development of a
new version of Postgres, so as it is possible to take actions in
pg_upgrade itself in this case (like 0ccfc28 for sql_identifier).

An area that is not covered yet is related to external modules, which
may create their own types.  The testing infrastructure of pg_upgrade is
not integrated yet with the external modules stored in core
(src/test/modules/ or contrib/, all use the same database name for their
tests so there would be an overlap).  This could be improved in the
future.

Author: Justin Pryzby
Reviewed-by: Jacob Champion, Peter Eisentraut, Tom Lane, Michael Paquier
Discussion: https://postgr.es/m/20201206180248.GI24052@telsasoft.com
Backpatch-through: 12

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a9993416f80f5d952cc392333011e4f7d399ec49

Modified Files
--------------
src/test/regress/expected/sanity_check.out |  1 +
src/test/regress/expected/type_sanity.out  | 95 ++++++++++++++++++++++++++++++
src/test/regress/sql/type_sanity.sql       | 93 +++++++++++++++++++++++++++++
3 files changed, 189 insertions(+)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2021-11-18 02:19 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 01:38 pgsql: Add table to regression tests for binary-compatibility checks in Michael Paquier <michael@paquier.xyz>
2021-11-18 02:19 ` Michael Paquier <michael@paquier.xyz>
2021-11-18 01:38 pgsql: Add table to regression tests for binary-compatibility checks in Michael Paquier <michael@paquier.xyz>
2021-11-18 01:38 pgsql: Add table to regression tests for binary-compatibility checks in Michael Paquier <michael@paquier.xyz>
2021-11-18 01:38 pgsql: Add table to regression tests for binary-compatibility checks in Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox