pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add table to regression tests for binary-compatibility checks in
Date: Thu, 18 Nov 2021 01:38:30 +0000
Message-ID: <E1mnWNi-0002SE-M3@gemulon.postgresql.org> (raw)

Add table to regression tests for binary-compatibility checks in pg_upgrade

This commit adds to the main regression test suite a table with all
the in-core data types (some exceptions apply).  This table is not
dropped, so as pg_upgrade would be able to check the binary
compatibility of the types tracked in the table.  If a new type is added
in core, this part of the tests would need a refresh but the tests are
designed to fail if that were to happen.

As this is useful for upgrades and that these rely on the objects
created in the regression test suite of the old version upgraded from,
a backpatch down to 12 is done, which is the last point where a binary
incompatible change has been done (7c15cef).  This will hopefully be
enough to find out if something gets broken during the development of a
new version of Postgres, so as it is possible to take actions in
pg_upgrade itself in this case (like 0ccfc28 for sql_identifier).

An area that is not covered yet is related to external modules, which
may create their own types.  The testing infrastructure of pg_upgrade is
not integrated yet with the external modules stored in core
(src/test/modules/ or contrib/, all use the same database name for their
tests so there would be an overlap).  This could be improved in the
future.

Author: Justin Pryzby
Reviewed-by: Jacob Champion, Peter Eisentraut, Tom Lane, Michael Paquier
Discussion: https://postgr.es/m/20201206180248.GI24052@telsasoft.com
Backpatch-through: 12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/755f04c72ef1bac5e34ab698aaf9d3a303ac5197

Modified Files
--------------
src/test/regress/expected/sanity_check.out |  1 +
src/test/regress/expected/type_sanity.out  | 97 ++++++++++++++++++++++++++++++
src/test/regress/sql/type_sanity.sql       | 95 +++++++++++++++++++++++++++++
3 files changed, 193 insertions(+)



view thread (5+ messages)  latest in thread

Message-ID: <E1mnWNi-0002SE-M3@gemulon.postgresql.org>
Permalink:  ../E1mnWNi-0002SE-M3@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mnWNi-0002SE-M3@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Add table to regression tests for binary-compatibility checks in
  In-Reply-To: <E1mnWNi-0002SE-M3@gemulon.postgresql.org>
  References: <E1mnWNi-0002SE-M3@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox