pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Reduce running time of jsonb_sqljson test
2+ messages / 2 participants
[nested] [flat]

* pgsql: Reduce running time of jsonb_sqljson test
@ 2022-04-06 14:30  Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 1 reply; 2+ messages in thread

From: Andrew Dunstan @ 2022-04-06 14:30 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reduce running time of jsonb_sqljson test

The test created a 1m row table in order to test parallel operation of
JSON_VALUE. However, this was more than were needed for the test, so
save time by halving it, and also by making the table unlogged.
Experimentation shows that this size is only a little above the number
required to generate the expected output.

Per gripe from Andres Freund

Discussion: https://postgr.es/m/20220406022118.3ocqvhxr6kciw5am@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2ef6f11b0c77ec323c688ddfd98ffabddb72c11d

Modified Files
--------------
src/test/regress/expected/jsonb_sqljson.out | 8 ++++----
src/test/regress/sql/jsonb_sqljson.sql      | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: pgsql: Reduce running time of jsonb_sqljson test
@ 2022-04-06 15:20  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2022-04-06 15:20 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; +Cc: pgsql-committers@lists.postgresql.org

Andrew Dunstan <andrew@dunslane.net> writes:
> The test created a 1m row table in order to test parallel operation of
> JSON_VALUE.

Egad.

> However, this was more than were needed for the test, so
> save time by halving it, and also by making the table unlogged.

This seems like a rather inappropriate fix.  I would say that a test
of this size does not belong in the core regression tests AT ALL.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-04-06 15:20 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-04-06 14:30 pgsql: Reduce running time of jsonb_sqljson test Andrew Dunstan <andrew@dunslane.net>
2022-04-06 15:20 ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox