pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgstat: add pgstat_copy_relation_stats().
Date: Wed, 06 Apr 2022 21:35:17 +0000
Message-ID: <E1ncDJ6-000dTv-Sr@gemulon.postgresql.org> (raw)

pgstat: add pgstat_copy_relation_stats().

Until now index_concurrently_swap() directly modified pgstat internal
datastructures. That will break with the introduction of shared memory
statistics and seems off architecturally.

This is done separately from the - quite large - shared memory statistics
patch to make review easier.

Author: Andres Freund <andres@anarazel.de>
Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-By: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220303021600.hs34ghqcw6zcokdh@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8ea7963fc741b6f403a544d56ad0ecf78e5237b1

Modified Files
--------------
src/backend/catalog/index.c                  | 26 ++--------------------
src/backend/utils/activity/pgstat_relation.c | 32 ++++++++++++++++++++++++++++
src/include/pgstat.h                         |  2 ++
3 files changed, 36 insertions(+), 24 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1ncDJ6-000dTv-Sr@gemulon.postgresql.org>
Permalink:  ../E1ncDJ6-000dTv-Sr@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ncDJ6-000dTv-Sr@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: pgstat: add pgstat_copy_relation_stats().
  In-Reply-To: <E1ncDJ6-000dTv-Sr@gemulon.postgresql.org>
  References: <E1ncDJ6-000dTv-Sr@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox