pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: pgstat: add pgstat_copy_relation_stats().
2+ messages / 2 participants
[nested] [flat]

* pgsql: pgstat: add pgstat_copy_relation_stats().
@ 2022-04-06 21:35  Andres Freund <andres@anarazel.de>
  0 siblings, 1 reply; 2+ messages in thread

From: Andres Freund @ 2022-04-06 21:35 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pgstat: add pgstat_copy_relation_stats().

Until now index_concurrently_swap() directly modified pgstat internal
datastructures. That will break with the introduction of shared memory
statistics and seems off architecturally.

This is done separately from the - quite large - shared memory statistics
patch to make review easier.

Author: Andres Freund <andres@anarazel.de>
Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-By: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220303021600.hs34ghqcw6zcokdh@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8ea7963fc741b6f403a544d56ad0ecf78e5237b1

Modified Files
--------------
src/backend/catalog/index.c                  | 26 ++--------------------
src/backend/utils/activity/pgstat_relation.c | 32 ++++++++++++++++++++++++++++
src/include/pgstat.h                         |  2 ++
3 files changed, 36 insertions(+), 24 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: pgsql: pgstat: add pgstat_copy_relation_stats().
@ 2022-04-06 23:58  Michael Paquier <michael@paquier.xyz>
  parent: Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2022-04-06 23:58 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org

On Wed, Apr 06, 2022 at 09:35:17PM +0000, Andres Freund wrote:
> pgstat: add pgstat_copy_relation_stats().
> 
> Until now index_concurrently_swap() directly modified pgstat internal
> datastructures. That will break with the introduction of shared memory
> statistics and seems off architecturally.
> 
> This is done separately from the - quite large - shared memory statistics
> patch to make review easier.

Thanks for this one.  This new routine makes sense.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-04-06 23:58 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-04-06 21:35 pgsql: pgstat: add pgstat_copy_relation_stats(). Andres Freund <andres@anarazel.de>
2022-04-06 23:58 ` Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox