pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
12+ messages / 3 participants
[nested] [flat]

Commits from this thread:
  2022-08-07 afe58c8b74 3aafd5da7d 61904503b7 8e5874964b 1626590f2e 9c30060007 f4beef1c2d  Remove unportable use of timezone in recent test
* pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
@ 2022-08-05 16:04 Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-05 16:10 ` Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-06 19:01 ` Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 2 replies; 12+ messages in thread

From: Alvaro Herrera @ 2022-08-05 16:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

That bit is unlogged and therefore it's wrong to consider it in WAL page
comparison.

Add a test that tickles the case, as branch testing technology allows.

This has been a problem ever since wal consistency checking was
introduced (commit a507b86900f6 for pg10), so backpatch to all supported
branches.

Author: 王海洋 (Haiyang Wang) <wanghaiyang.001@bytedance.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CACciXAD2UvLMOhc4jX9VvOKt7DtYLr3OYRBhvOZ-jRxtzc_7Jg@mail.gmail.com
Discussion: https://postgr.es/m/CACciXADOfErX9Bx0nzE_SkdfXr6Bbpo5R=v_B6MUTEYW4ya+cg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e44dae07f931383151e2eb34ed9b4cbf4bf14482

Modified Files
--------------
src/backend/access/brin/brin_pageops.c        |  7 ++-
src/backend/access/brin/brin_xlog.c           |  6 +++
src/test/modules/brin/Makefile                |  2 +-
src/test/modules/brin/t/02_wal_consistency.pl | 75 +++++++++++++++++++++++++++
4 files changed, 88 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
  2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2022-08-05 16:10 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
  1 sibling, 0 replies; 12+ messages in thread

From: Alvaro Herrera @ 2022-08-05 16:10 UTC (permalink / raw)
  To: pgsql-hackers@lists.postgresql.org

On 2022-Aug-05, Alvaro Herrera wrote:

> Add a test that tickles the case, as branch testing technology allows.

One point here is that this confirms that the backpatched renaming alias
for PostgreSQL::Test::Cluster is working well.

Another is that, as far as I know, this is the going to be the only case
of any code being run under wal_consistency_checking=[not off]
regularly.  027_stream_regress.pl is equipped to do so, but as far as I
know we have no buildfarm animal with PG_EXTRA_TESTS set it so.  I did
consider to make this new test conditional on having that flag be on,
but I disregarded it because of that.

A third point is that in branches 15+ I made it use pg_walinspect to
ensure that the desired WAL record is being emitted.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/





^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
  2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2022-08-06 19:01 ` Tom Lane <tgl@sss.pgh.pa.us>
  2022-08-06 20:03   ` Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Álvaro Herrera <alvherre@alvh.no-ip.org>
  1 sibling, 1 reply; 12+ messages in thread

From: Tom Lane @ 2022-08-06 19:01 UTC (permalink / raw)
  To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-committers@lists.postgresql.org

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

snapper doesn't like this too much, because

error running SQL: 'psql:<stdin>:17: ERROR:  time zone "america/punta_arenas" not recognized
CONTEXT:  PL/pgSQL function inline_code_block line 3 during statement block local variable initialization'

Is there a particular reason why you used that zone, rather than say UTC?

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
  2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-06 19:01 ` Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-08-06 20:03   ` Álvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-07 08:21     ` Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Álvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 1 reply; 12+ messages in thread

From: Álvaro Herrera @ 2022-08-06 20:03 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org

On Sat, Aug 6, 2022, at 9:01 PM, Tom Lane wrote:
> snapper doesn't like this too much, because
> 
> error running SQL: 'psql:<stdin>:17: ERROR:  time zone "america/punta_arenas" not recognized
> CONTEXT:  PL/pgSQL function inline_code_block line 3 during statement block local variable initialization'
> 
> Is there a particular reason why you used that zone, rather than say UTC?

None very good — I just wanted it to be not Moscow, which it was in the OP. I'll change it — to UTC, I suppose.

^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
  2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-06 19:01 ` Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Tom Lane <tgl@sss.pgh.pa.us>
  2022-08-06 20:03   ` Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Álvaro Herrera <alvherre@alvh.no-ip.org>
@ 2022-08-07 08:21     ` Álvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-07 13:44       ` Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 12+ messages in thread

From: Álvaro Herrera @ 2022-08-07 08:21 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org

On 2022-Aug-06, Álvaro Herrera wrote:

> On Sat, Aug 6, 2022, at 9:01 PM, Tom Lane wrote:
> > snapper doesn't like this too much, because
> > 
> > error running SQL: 'psql:<stdin>:17: ERROR:  time zone "america/punta_arenas" not recognized
> > CONTEXT:  PL/pgSQL function inline_code_block line 3 during statement block local variable initialization'
> > 
> > Is there a particular reason why you used that zone, rather than say UTC?
> 
> None very good — I just wanted it to be not Moscow, which it was in
> the OP. I'll change it — to UTC, I suppose.

Done.

-- 
Álvaro Herrera





^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
  2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-06 19:01 ` Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Tom Lane <tgl@sss.pgh.pa.us>
  2022-08-06 20:03   ` Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Álvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-07 08:21     ` Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Álvaro Herrera <alvherre@alvh.no-ip.org>
@ 2022-08-07 13:44       ` Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2022-08-07 13:44 UTC (permalink / raw)
  To: Álvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-committers@lists.postgresql.org

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org> writes:
> On 2022-Aug-06, Álvaro Herrera wrote:
>> None very good — I just wanted it to be not Moscow, which it was in
>> the OP. I'll change it — to UTC, I suppose.

> Done.

Thanks.  I wondered why this was a problem, when we have various
other dependencies on specific zone names in the tests.  The
answer seems to be that America/Punta_Arenas is a fairly new
zone name: it was introduced in tzdata 2017a [1].  So snapper's
tzdata must be older than that.  I see it is using the system
tzdata not our own:

                      '--with-system-tzdata=/usr/share/zoneinfo',

You would've been fine with America/Santiago, likely :-(

			regards, tom lane

[1] http://mm.icann.org/pipermail/tz-announce/2017-February/000045.html





^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
@ 2022-08-05 16:04 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 12+ messages in thread

From: Alvaro Herrera @ 2022-08-05 16:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

That bit is unlogged and therefore it's wrong to consider it in WAL page
comparison.

Add a test that tickles the case, as branch testing technology allows.

This has been a problem ever since wal consistency checking was
introduced (commit a507b86900f6 for pg10), so backpatch to all supported
branches.

Author: 王海洋 (Haiyang Wang) <wanghaiyang.001@bytedance.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CACciXAD2UvLMOhc4jX9VvOKt7DtYLr3OYRBhvOZ-jRxtzc_7Jg@mail.gmail.com
Discussion: https://postgr.es/m/CACciXADOfErX9Bx0nzE_SkdfXr6Bbpo5R=v_B6MUTEYW4ya+cg@mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2cff3025906c657297ef7bf323fa715f81d20038

Modified Files
--------------
src/backend/access/brin/brin_pageops.c        |  7 ++-
src/backend/access/brin/brin_xlog.c           |  6 +++
src/test/modules/brin/Makefile                |  2 +-
src/test/modules/brin/t/02_wal_consistency.pl | 75 +++++++++++++++++++++++++++
4 files changed, 88 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
@ 2022-08-05 16:04 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 12+ messages in thread

From: Alvaro Herrera @ 2022-08-05 16:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

That bit is unlogged and therefore it's wrong to consider it in WAL page
comparison.

Add a test that tickles the case, as branch testing technology allows.

This has been a problem ever since wal consistency checking was
introduced (commit a507b86900f6 for pg10), so backpatch to all supported
branches.

Author: 王海洋 (Haiyang Wang) <wanghaiyang.001@bytedance.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CACciXAD2UvLMOhc4jX9VvOKt7DtYLr3OYRBhvOZ-jRxtzc_7Jg@mail.gmail.com
Discussion: https://postgr.es/m/CACciXADOfErX9Bx0nzE_SkdfXr6Bbpo5R=v_B6MUTEYW4ya+cg@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/541f41d4fa783ce213f15d4f5faaca5bb7a50559

Modified Files
--------------
src/backend/access/brin/brin_pageops.c        |  7 ++-
src/backend/access/brin/brin_xlog.c           |  6 +++
src/test/modules/brin/t/02_wal_consistency.pl | 64 +++++++++++++++++++++++++++
3 files changed, 76 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
@ 2022-08-05 16:04 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 12+ messages in thread

From: Alvaro Herrera @ 2022-08-05 16:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

That bit is unlogged and therefore it's wrong to consider it in WAL page
comparison.

Add a test that tickles the case, as branch testing technology allows.

This has been a problem ever since wal consistency checking was
introduced (commit a507b86900f6 for pg10), so backpatch to all supported
branches.

Author: 王海洋 (Haiyang Wang) <wanghaiyang.001@bytedance.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CACciXAD2UvLMOhc4jX9VvOKt7DtYLr3OYRBhvOZ-jRxtzc_7Jg@mail.gmail.com
Discussion: https://postgr.es/m/CACciXADOfErX9Bx0nzE_SkdfXr6Bbpo5R=v_B6MUTEYW4ya+cg@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/de31e6f81e84d53b1cb3d2f14705e4895a4b23d0

Modified Files
--------------
src/backend/access/brin/brin_pageops.c        |  7 ++-
src/backend/access/brin/brin_xlog.c           |  6 +++
src/test/modules/brin/t/02_wal_consistency.pl | 64 +++++++++++++++++++++++++++
3 files changed, 76 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
@ 2022-08-05 16:04 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 12+ messages in thread

From: Alvaro Herrera @ 2022-08-05 16:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

That bit is unlogged and therefore it's wrong to consider it in WAL page
comparison.

Add a test that tickles the case, as branch testing technology allows.

This has been a problem ever since wal consistency checking was
introduced (commit a507b86900f6 for pg10), so backpatch to all supported
branches.

Author: 王海洋 (Haiyang Wang) <wanghaiyang.001@bytedance.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CACciXAD2UvLMOhc4jX9VvOKt7DtYLr3OYRBhvOZ-jRxtzc_7Jg@mail.gmail.com
Discussion: https://postgr.es/m/CACciXADOfErX9Bx0nzE_SkdfXr6Bbpo5R=v_B6MUTEYW4ya+cg@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/49b85e4812d78b4c4601301209597a35c117b16b

Modified Files
--------------
src/backend/access/brin/brin_pageops.c        |  7 ++-
src/backend/access/brin/brin_xlog.c           |  6 +++
src/test/modules/brin/t/02_wal_consistency.pl | 64 +++++++++++++++++++++++++++
3 files changed, 76 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
@ 2022-08-05 16:04 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 12+ messages in thread

From: Alvaro Herrera @ 2022-08-05 16:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

That bit is unlogged and therefore it's wrong to consider it in WAL page
comparison.

Add a test that tickles the case, as branch testing technology allows.

This has been a problem ever since wal consistency checking was
introduced (commit a507b86900f6 for pg10), so backpatch to all supported
branches.

Author: 王海洋 (Haiyang Wang) <wanghaiyang.001@bytedance.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CACciXAD2UvLMOhc4jX9VvOKt7DtYLr3OYRBhvOZ-jRxtzc_7Jg@mail.gmail.com
Discussion: https://postgr.es/m/CACciXADOfErX9Bx0nzE_SkdfXr6Bbpo5R=v_B6MUTEYW4ya+cg@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/39e45d3ceca7c9cb2240cd68b22f163a610e0ace

Modified Files
--------------
src/backend/access/brin/brin_pageops.c        |  7 ++-
src/backend/access/brin/brin_xlog.c           |  6 +++
src/test/modules/brin/t/02_wal_consistency.pl | 64 +++++++++++++++++++++++++++
3 files changed, 76 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
@ 2022-08-05 16:04 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 12+ messages in thread

From: Alvaro Herrera @ 2022-08-05 16:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

That bit is unlogged and therefore it's wrong to consider it in WAL page
comparison.

Add a test that tickles the case, as branch testing technology allows.

This has been a problem ever since wal consistency checking was
introduced (commit a507b86900f6 for pg10), so backpatch to all supported
branches.

Author: 王海洋 (Haiyang Wang) <wanghaiyang.001@bytedance.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CACciXAD2UvLMOhc4jX9VvOKt7DtYLr3OYRBhvOZ-jRxtzc_7Jg@mail.gmail.com
Discussion: https://postgr.es/m/CACciXADOfErX9Bx0nzE_SkdfXr6Bbpo5R=v_B6MUTEYW4ya+cg@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e797c7a6f76bc21e77b59bb508ed8b3617ff9461

Modified Files
--------------
src/backend/access/brin/brin_pageops.c        |  7 ++-
src/backend/access/brin/brin_xlog.c           |  6 +++
src/test/modules/brin/t/02_wal_consistency.pl | 64 +++++++++++++++++++++++++++
3 files changed, 76 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread


end of thread, other threads:[~2022-08-07 13:44 UTC | newest]

Thread overview: 12+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-08-05 16:10 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-08-06 19:01 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-08-06 20:03   ` Álvaro Herrera <alvherre@alvh.no-ip.org>
2022-08-07 08:21     ` Álvaro Herrera <alvherre@alvh.no-ip.org>
2022-08-07 13:44       ` Tom Lane <tgl@sss.pgh.pa.us>
2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-08-05 16:04 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking Alvaro Herrera <alvherre@alvh.no-ip.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox