pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rely on __func__ being supported
Date: Sun, 07 Aug 2022 16:36:40 +0000
Message-ID: <E1oKjGa-000kX6-3d@gemulon.postgresql.org> (raw)

Rely on __func__ being supported

Previously we fell back to __FUNCTION__ and then NULL. As __func__ is in C99
that shouldn't be necessary anymore.

Solution.pm defined HAVE_FUNCNAME__FUNCTION instead of
HAVE_FUNCNAME__FUNC (originating in 4164e6636e2), as at some point in the past
MSVC only supported __FUNCTION__. Our minimum version supports __func__.

Reviewed-By: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/20220807012914.ydz73yte6j3coulo@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/320f92b744b44f961e5d56f5f21de003e8027a7f

Modified Files
--------------
config/c-compiler.m4              | 26 -----------------
configure                         | 61 ---------------------------------------
configure.ac                      |  1 -
src/backend/storage/lmgr/s_lock.c |  2 +-
src/include/c.h                   | 11 -------
src/include/pg_config.h.in        |  6 ----
src/include/storage/s_lock.h      |  4 +--
src/include/utils/elog.h          |  4 +--
src/tools/msvc/Solution.pm        |  2 --
9 files changed, 5 insertions(+), 112 deletions(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1oKjGa-000kX6-3d@gemulon.postgresql.org>
Permalink:  ../E1oKjGa-000kX6-3d@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oKjGa-000kX6-3d@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: Rely on __func__ being supported
  In-Reply-To: <E1oKjGa-000kX6-3d@gemulon.postgresql.org>
  References: <E1oKjGa-000kX6-3d@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox