pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove further unwanted linker flags from perl_embed_ldflags
Date: Tue, 23 Aug 2022 14:29:49 +0000
Message-ID: <E1oQUuZ-000rD1-TO@gemulon.postgresql.org> (raw)

Remove further unwanted linker flags from perl_embed_ldflags

Remove the contents of $Config{ldflags} from ExtUtils::Embed's ldopts,
like we already do with $Config{ccdlflags}.  Those flags are the
choices of those who built the Perl installation, which are not
necessarily appropriate for building PostgreSQL.  What we really want
from ldopts are the options identifying the location and name of the
libperl library, but unfortunately it doesn't appear possible to get
that separately from the other stuff.

The motivation for this was to strip -mmacosx-version-min options.  We
already did something similar for the -arch option.  Both of those are
now covered by this more general approach.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/flat/8c4fcb72-2574-ff7c-4c25-1f032d4a2a57%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b4e936859dc441102eb0b6fb7a104f3948c90490

Modified Files
--------------
config/perl.m4 | 10 +++++-----
configure      |  4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1oQUuZ-000rD1-TO@gemulon.postgresql.org>
Permalink:  ../E1oQUuZ-000rD1-TO@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oQUuZ-000rD1-TO@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Remove further unwanted linker flags from perl_embed_ldflags
  In-Reply-To: <E1oQUuZ-000rD1-TO@gemulon.postgresql.org>
  References: <E1oQUuZ-000rD1-TO@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox