From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove further unwanted linker flags from perl_embed_ldflags
Date: Fri, 2 Sep 2022 20:18:21 +0900
Message-ID: <YxHmfSiZquOAFobV@paquier.xyz> (raw)
In-Reply-To: <E1oQUuZ-000rD1-TO@gemulon.postgresql.org>
References: <E1oQUuZ-000rD1-TO@gemulon.postgresql.org>
Hi Peter,
On Tue, Aug 23, 2022 at 02:29:49PM +0000, Peter Eisentraut wrote:
> Remove further unwanted linker flags from perl_embed_ldflags
>
> Remove the contents of $Config{ldflags} from ExtUtils::Embed's ldopts,
> like we already do with $Config{ccdlflags}. Those flags are the
> choices of those who built the Perl installation, which are not
> necessarily appropriate for building PostgreSQL. What we really want
> from ldopts are the options identifying the location and name of the
> libperl library, but unfortunately it doesn't appear possible to get
> that separately from the other stuff.
>
> The motivation for this was to strip -mmacosx-version-min options. We
> already did something similar for the -arch option. Both of those are
> now covered by this more general approach.
>
> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
> Reviewed-by: Andres Freund <andres@anarazel.de>
> Discussion: https://www.postgresql.org/message-id/flat/8c4fcb72-2574-ff7c-4c25-1f032d4a2a57%40enterprisedb.com
lorikeet (cygwin) has been failing for 9 days now on HEAD, while the
first failure happened here:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lorikeet&dt=2022-08-24%2000%3A11%3A00
This means that we have a problem for commits in the range of
c981879814~1..869e56a3. And in this range, it seems to me that this
commit is the primary suspect. Could you look at that?
Thanks,
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, peter@eisentraut.org
Subject: Re: pgsql: Remove further unwanted linker flags from perl_embed_ldflags
In-Reply-To: <YxHmfSiZquOAFobV@paquier.xyz>
References: <E1oQUuZ-000rD1-TO@gemulon.postgresql.org> <YxHmfSiZquOAFobV@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox