pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove ancient special case code for dropping oid columns
2+ messages / 1 participants
[nested] [flat]

* pgsql: Remove ancient special case code for adding oid columns
@ 2023-07-12 14:21 Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Peter Eisentraut @ 2023-07-12 14:21 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove ancient special case code for adding oid columns

The special handling of negative attribute numbers in
ATExecAddColumn() was introduced to support SET WITH OIDS (commit
6d1e361852).  But that feature doesn't exist anymore, so we can revert
to the previous, simpler version.  In passing, also remove an obsolete
comment about OID support.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5eaa0e92ee2f94994c55c02d01b3feabc6c35f54

Modified Files
--------------
src/backend/commands/tablecmds.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Remove ancient special case code for dropping oid columns
@ 2023-07-12 14:21 Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Peter Eisentraut @ 2023-07-12 14:21 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove ancient special case code for dropping oid columns

The special handling of negative attribute numbers in
RemoveAttributeById() was introduced to support SET WITHOUT OIDS
(commit 24614a9880).  But that feature doesn't exist anymore, so we
can revert to the previous, simpler version.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7ef2912519fdea0dd0f6747c4dc008c99dc51e90

Modified Files
--------------
src/backend/catalog/heap.c | 99 ++++++++++++++++++++--------------------------
1 file changed, 43 insertions(+), 56 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2023-07-12 14:21 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-07-12 14:21 pgsql: Remove ancient special case code for adding oid columns Peter Eisentraut <peter@eisentraut.org>
2023-07-12 14:21 pgsql: Remove ancient special case code for dropping oid columns Peter Eisentraut <peter@eisentraut.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox