pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove ancient special case code for dropping oid columns
Date: Wed, 12 Jul 2023 14:21:34 +0000
Message-ID: <E1qJaik-0000ps-2K@gemulon.postgresql.org> (raw)

Remove ancient special case code for dropping oid columns

The special handling of negative attribute numbers in
RemoveAttributeById() was introduced to support SET WITHOUT OIDS
(commit 24614a9880).  But that feature doesn't exist anymore, so we
can revert to the previous, simpler version.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7ef2912519fdea0dd0f6747c4dc008c99dc51e90

Modified Files
--------------
src/backend/catalog/heap.c | 99 ++++++++++++++++++++--------------------------
1 file changed, 43 insertions(+), 56 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1qJaik-0000ps-2K@gemulon.postgresql.org>
Permalink:  ../E1qJaik-0000ps-2K@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qJaik-0000ps-2K@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove ancient special case code for dropping oid columns
  In-Reply-To: <E1qJaik-0000ps-2K@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox