pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: In basebackup.c, refactor to create verify_page_checksum.
Date: Tue, 03 Oct 2023 14:47:50 +0000
Message-ID: <E1qnggg-007JdY-RY@gemulon.postgresql.org> (raw)

In basebackup.c, refactor to create verify_page_checksum.

If checksum verification fails for a particular page, we reread the
page and try one more time. The code that does this somewhat complex
and difficult to follow. Move some of the logic into a new function
and rearrange the code a bit to try to make it clearer. This way,
we don't need the block_retry Boolean, a couple of other variables
move from sendFile() into the new function, and some code is now less
deeply indented.

Patch by me, reviewed by David Steele.

Discussion: http://postgr.es/m/CA+TgmoYt5jXH4U6cu1dm9Oe2FTn1aae6hBNhZzJJjyjbE_zYig@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/053183138a7a11408d6faa9281001ff7b1ffee2e

Modified Files
--------------
src/backend/backup/basebackup.c | 188 ++++++++++++++++++++++------------------
1 file changed, 104 insertions(+), 84 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1qnggg-007JdY-RY@gemulon.postgresql.org>
Permalink:  ../E1qnggg-007JdY-RY@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qnggg-007JdY-RY@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: In basebackup.c, refactor to create verify_page_checksum.
  In-Reply-To: <E1qnggg-007JdY-RY@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox