pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Optimize various aggregate deserialization functions
Date: Mon, 09 Oct 2023 04:25:39 +0000
Message-ID: <E1qphpq-000joR-Kq@gemulon.postgresql.org> (raw)

Optimize various aggregate deserialization functions

The serialized representation of an internal aggregate state is a bytea
value.  In each deserial function, in order to "receive" the bytea value
we appended it onto a short-lived StringInfoData using
appendBinaryStringInfo.  This was a little wasteful as it meant having to
palloc memory, copy a (possibly long) series of bytes then later pfree
that memory.  Instead of going to this extra trouble, we can just fake up
a StringInfoData and point the data directly at the bytea's payload.  This
should help increase the performance of internal aggregate
deserialization.

Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/CAApHDvr=e-YOigriSHHm324a40HPqcUhSp6pWWgjz5WwegR=cQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/608fd198def5390c3490bfe903730207dfd8eeb4

Modified Files
--------------
src/backend/utils/adt/array_userfuncs.c | 24 ++++++++---------
src/backend/utils/adt/numeric.c         | 48 ++++++++++++++++-----------------
src/backend/utils/adt/varlena.c         | 12 ++++-----
3 files changed, 42 insertions(+), 42 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1qphpq-000joR-Kq@gemulon.postgresql.org>
Permalink:  ../E1qphpq-000joR-Kq@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1qphpq-000joR-Kq@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Optimize various aggregate deserialization functions
  In-Reply-To: <E1qphpq-000joR-Kq@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox