pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
3+ messages / 3 participants
[nested] [flat]
* pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
@ 2023-12-19 20:29 Robert Haas <rhaas@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: Robert Haas @ 2023-12-19 20:29 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
This makes it possible for the code to be easily reused by other
client-side tools, and/or by the server.
Patch by me. Review of this patch in particular by at least Peter
Eisentraut; reviewers for the patch series in general include Dilip
Kumar, Andres Fruend, David Steele, Álvaro Herrera, and Jakub Wartak.
Discussion: http://postgr.es/m/CA+TgmoZ6UGZVnSy5iak6s6+AXu_DewXovDjhLs3-su6nmU_x_g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/aafc07c7a191bc807c77fe2a044006a5db07faba
Modified Files
--------------
src/bin/pg_verifybackup/Makefile | 1 -
src/bin/pg_verifybackup/meson.build | 1 -
src/bin/pg_verifybackup/nls.mk | 4 ++--
src/bin/pg_verifybackup/pg_verifybackup.c | 2 +-
src/common/Makefile | 1 +
src/common/meson.build | 1 +
src/{bin/pg_verifybackup => common}/parse_manifest.c | 4 ++--
src/{bin/pg_verifybackup => include/common}/parse_manifest.h | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
@ 2023-12-20 01:01 Michael Paquier <michael@paquier.xyz>
parent: Robert Haas <rhaas@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: Michael Paquier @ 2023-12-20 01:01 UTC (permalink / raw)
To: Robert Haas <rhaas@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Dec 19, 2023 at 08:29:18PM +0000, Robert Haas wrote:
> Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
>
> This makes it possible for the code to be easily reused by other
> client-side tools, and/or by the server.
>
> Patch by me. Review of this patch in particular by at least Peter
> Eisentraut; reviewers for the patch series in general include Dilip
> Kumar, Andres Fruend, David Steele, Álvaro Herrera, and Jakub Wartak.
Worth noting that this has forgotten to update @pgcommonallfiles in
Mkvcbuild.pm so this would have failed a build with src/build/msvc/.
Or you counted on me here, relying on the scripts to be gone? ;p
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
@ 2023-12-20 02:16 Robert Haas <robertmhaas@gmail.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 3+ messages in thread
From: Robert Haas @ 2023-12-20 02:16 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
On Tue, Dec 19, 2023 at 8:01 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Dec 19, 2023 at 08:29:18PM +0000, Robert Haas wrote:
> > Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
> >
> > This makes it possible for the code to be easily reused by other
> > client-side tools, and/or by the server.
> >
> > Patch by me. Review of this patch in particular by at least Peter
> > Eisentraut; reviewers for the patch series in general include Dilip
> > Kumar, Andres Fruend, David Steele, Álvaro Herrera, and Jakub Wartak.
>
> Worth noting that this has forgotten to update @pgcommonallfiles in
> Mkvcbuild.pm so this would have failed a build with src/build/msvc/.
> Or you counted on me here, relying on the scripts to be gone? ;p
To be honest, I counted on CI to tell me whether it still builds everywhere.
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-12-20 02:16 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-12-19 20:29 pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common. Robert Haas <rhaas@postgresql.org>
2023-12-20 01:01 ` Michael Paquier <michael@paquier.xyz>
2023-12-20 02:16 ` Robert Haas <robertmhaas@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox