pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
Date: Wed, 20 Dec 2023 10:01:16 +0900
Message-ID: <ZYI83OBanVOfOHVr@paquier.xyz> (raw)
In-Reply-To: <E1rFgiL-00AyMV-KD@gemulon.postgresql.org>
References: <E1rFgiL-00AyMV-KD@gemulon.postgresql.org>

On Tue, Dec 19, 2023 at 08:29:18PM +0000, Robert Haas wrote:
> Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
> 
> This makes it possible for the code to be easily reused by other
> client-side tools, and/or by the server.
> 
> Patch by me. Review of this patch in particular by at least Peter
> Eisentraut; reviewers for the patch series in general include Dilip
> Kumar, Andres Fruend, David Steele, Álvaro Herrera, and Jakub Wartak.

Worth noting that this has forgotten to update @pgcommonallfiles in
Mkvcbuild.pm so this would have failed a build with src/build/msvc/.
Or you counted on me here, relying on the scripts to be gone?  ;p
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (3+ messages)  latest in thread

Message-ID: <ZYI83OBanVOfOHVr@paquier.xyz>
Permalink:  ../ZYI83OBanVOfOHVr@paquier.xyz/
Also on:    postgresql.org/message-id/ZYI83OBanVOfOHVr@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
  In-Reply-To: <ZYI83OBanVOfOHVr@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox