pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Remove MSVC scripts
5+ messages / 3 participants
[nested] [flat]
* pgsql: Remove MSVC scripts
@ 2023-12-20 00:45 Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 5+ messages in thread
From: Michael Paquier @ 2023-12-20 00:45 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove MSVC scripts
This commit removes all the scripts located in src/tools/msvc/ to build
PostgreSQL with Visual Studio on Windows, meson becoming the recommended
way to achieve that. The scripts held some information that is still
relevant with meson, information kept and moved to better locations.
Comments that referred directly to the scripts are removed.
All the documentation still relevant that was in install-windows.sgml
has been moved to installation.sgml under a new subsection for Visual.
All the content specific to the scripts is removed. Some adjustments
for the documentation are planned in a follow-up set of changes.
Author: Michael Paquier
Reviewed-by: Peter Eisentraut, Andres Freund
Discussion: https://postgr.es/m/ZQzp_VMJcerM1Cs_@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1301c80b2167feb658a738fa4ceb1c23d0991e23
Modified Files
--------------
config/perl.m4 | 15 +-
doc/src/sgml/filelist.sgml | 1 -
doc/src/sgml/install-windows.sgml | 588 -----------
doc/src/sgml/installation.sgml | 314 +++++-
doc/src/sgml/postgres.sgml | 1 -
doc/src/sgml/standalone-profile.xsl | 4 -
meson.build | 1 -
src/backend/meson.build | 2 +-
src/bin/pg_basebackup/Makefile | 3 -
src/bin/pgevent/meson.build | 3 +-
src/common/Makefile | 11 +-
src/common/meson.build | 9 +-
src/interfaces/libpq/Makefile | 3 -
src/port/Makefile | 2 -
src/port/pgstrsignal.c | 3 -
src/tools/msvc/.gitignore | 3 -
src/tools/msvc/Install.pm | 748 --------------
src/tools/msvc/MSBuildProject.pm | 508 ----------
src/tools/msvc/Mkvcbuild.pm | 1220 -----------------------
src/tools/msvc/Project.pm | 482 ---------
src/tools/msvc/README | 99 --
src/tools/msvc/Solution.pm | 1356 --------------------------
src/tools/msvc/VSObjectFactory.pm | 174 ----
src/tools/msvc/build.bat | 6 -
src/tools/msvc/build.pl | 92 --
src/tools/msvc/clean.bat | 160 ---
src/tools/msvc/config_default.pl | 32 -
src/tools/msvc/dummylib/README | 13 -
src/tools/msvc/dummylib/Win32.pm | 7 -
src/tools/msvc/dummylib/Win32/Registry.pm | 16 -
src/tools/msvc/dummylib/Win32API/File.pm | 17 -
src/tools/msvc/ecpg_regression.proj | 64 --
src/tools/msvc/install.bat | 6 -
src/tools/msvc/install.pl | 39 -
src/tools/msvc/mkvcbuild.pl | 31 -
src/tools/msvc/pgbison.bat | 7 -
src/tools/msvc/pgbison.pl | 55 --
src/tools/msvc/pgflex.bat | 7 -
src/tools/msvc/pgflex.pl | 108 --
src/tools/msvc/vcregress.bat | 6 -
src/tools/msvc/vcregress.pl | 664 -------------
src/tools/{msvc/gendef.pl => msvc_gendef.pl} | 4 +-
src/tools/perlcheck/pgperlsyncheck | 2 +-
43 files changed, 319 insertions(+), 6567 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Remove MSVC scripts
@ 2023-12-20 14:19 Robert Haas <robertmhaas@gmail.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 5+ messages in thread
From: Robert Haas @ 2023-12-20 14:19 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Dec 19, 2023 at 7:45 PM Michael Paquier <michael@paquier.xyz> wrote:
> Remove MSVC scripts
I think it's because of this commit that koel and crake now have this complaint:
<blah blah lots of output>
./src/tools/version_stamp.pl syntax OK
Can't locate Win32/Registry.pm in @INC (you may need to install the
Win32::Registry module) (@INC entries checked: src/test/perl
src/tools/msvc src/backend/catalog src/backend/utils/mb/Unicode
src/bin/pg_rewind src/test/ssl/t src/tools/msvc/dummylib
/usr/local/lib64/perl5/5.38 /usr/local/share/perl5/5.38
/usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl
/usr/lib64/perl5 /usr/share/perl5) at ./src/tools/win32tzlist.pl line
21.
BEGIN failed--compilation aborted at ./src/tools/win32tzlist.pl line 21.
win32tzlist.pl still says "use Win32::Registry" but the commit removed
src/tools/msvc/dummylib/Win32/Registry.pm.
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Remove MSVC scripts
@ 2023-12-20 15:35 Andrew Dunstan <andrew@dunslane.net>
parent: Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Dunstan @ 2023-12-20 15:35 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
On 2023-12-20 We 09:19, Robert Haas wrote:
> On Tue, Dec 19, 2023 at 7:45 PM Michael Paquier <michael@paquier.xyz> wrote:
>> Remove MSVC scripts
> I think it's because of this commit that koel and crake now have this complaint:
>
> <blah blah lots of output>
> ./src/tools/version_stamp.pl syntax OK
> Can't locate Win32/Registry.pm in @INC (you may need to install the
> Win32::Registry module) (@INC entries checked: src/test/perl
> src/tools/msvc src/backend/catalog src/backend/utils/mb/Unicode
> src/bin/pg_rewind src/test/ssl/t src/tools/msvc/dummylib
> /usr/local/lib64/perl5/5.38 /usr/local/share/perl5/5.38
> /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl
> /usr/lib64/perl5 /usr/share/perl5) at ./src/tools/win32tzlist.pl line
> 21.
> BEGIN failed--compilation aborted at ./src/tools/win32tzlist.pl line 21.
>
> win32tzlist.pl still says "use Win32::Registry" but the commit removed
> src/tools/msvc/dummylib/Win32/Registry.pm.
>
Yeah, the commit removed our dummy version of Win32/Registry.pm. I have
disabled the test for that file on branches later than 16, and koel and
crake are back to green.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Remove MSVC scripts
@ 2023-12-20 18:11 Robert Haas <robertmhaas@gmail.com>
parent: Andrew Dunstan <andrew@dunslane.net>
0 siblings, 1 reply; 5+ messages in thread
From: Robert Haas @ 2023-12-20 18:11 UTC (permalink / raw)
To: Andrew Dunstan <andrew@dunslane.net>; +Cc: Michael Paquier <michael@paquier.xyz>; pgsql-committers@lists.postgresql.org
On Wed, Dec 20, 2023 at 10:35 AM Andrew Dunstan <andrew@dunslane.net> wrote:
> Yeah, the commit removed our dummy version of Win32/Registry.pm. I have
> disabled the test for that file on branches later than 16, and koel and
> crake are back to green.
Great, thanks for the quick work.
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Remove MSVC scripts
@ 2023-12-20 23:22 Michael Paquier <michael@paquier.xyz>
parent: Robert Haas <robertmhaas@gmail.com>
0 siblings, 0 replies; 5+ messages in thread
From: Michael Paquier @ 2023-12-20 23:22 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: Andrew Dunstan <andrew@dunslane.net>; pgsql-committers@lists.postgresql.org
On Wed, Dec 20, 2023 at 01:11:17PM -0500, Robert Haas wrote:
> On Wed, Dec 20, 2023 at 10:35 AM Andrew Dunstan <andrew@dunslane.net> wrote:
>> Yeah, the commit removed our dummy version of Win32/Registry.pm. I have
>> disabled the test for that file on branches later than 16, and koel and
>> crake are back to green.
>
> Great, thanks for the quick work.
Didn't see this one coming.. This has been reported by the buildfarm
after I went offline for the day. Thanks for the quick fix, Andrew!
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2023-12-20 23:22 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-12-20 00:45 pgsql: Remove MSVC scripts Michael Paquier <michael@paquier.xyz>
2023-12-20 14:19 ` Robert Haas <robertmhaas@gmail.com>
2023-12-20 15:35 ` Andrew Dunstan <andrew@dunslane.net>
2023-12-20 18:11 ` Robert Haas <robertmhaas@gmail.com>
2023-12-20 23:22 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox