pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Update obsolete index scan TID comments.
2+ messages / 2 participants
[nested] [flat]
* pgsql: Update obsolete index scan TID comments.
@ 2024-03-11 22:07 Peter Geoghegan <pg@bowt.ie>
2024-05-17 10:00 ` Re: pgsql: Update obsolete index scan TID comments. Alexander Lakhin <exclusion@gmail.com>
0 siblings, 1 reply; 2+ messages in thread
From: Peter Geoghegan @ 2024-03-11 22:07 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Update obsolete index scan TID comments.
Oversight in commit c2fe139c20.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3045324214467dd3f0bef31f6f33562b9eb93aa3
Modified Files
--------------
src/backend/access/hash/hashsearch.c | 6 +++---
src/backend/access/nbtree/nbtsearch.c | 10 +++++-----
2 files changed, 8 insertions(+), 8 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: pgsql: Update obsolete index scan TID comments.
2024-03-11 22:07 pgsql: Update obsolete index scan TID comments. Peter Geoghegan <pg@bowt.ie>
@ 2024-05-17 10:00 ` Alexander Lakhin <exclusion@gmail.com>
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Lakhin @ 2024-05-17 10:00 UTC (permalink / raw)
To: Peter Geoghegan <pg@bowt.ie>; pgsql-committers@lists.postgresql.org
Hello Peter,
12.03.2024 01:07, Peter Geoghegan wrote:
> Update obsolete index scan TID comments.
>
> Oversight in commit c2fe139c20.
I found one more obsolete comment mentioning xs_ctup:
/*
* For IndexOnlyScan, the tuple stored in ss_ScanTupleSlot may be
* a virtual tuple that does not have the ctid column, so we have
* to get the TID from xs_ctup.t_self.
*/
IndexScanDesc scan = ((IndexOnlyScanState *) scanstate)->ioss_ScanDesc;
*current_tid = scan->xs_heaptid;
Maybe you would like to fix it too...
Best regards,
Alexander
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-05-17 10:00 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-03-11 22:07 pgsql: Update obsolete index scan TID comments. Peter Geoghegan <pg@bowt.ie>
2024-05-17 10:00 ` Alexander Lakhin <exclusion@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox