pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Stabilize test of BRIN parallel create
Date: Tue, 16 Apr 2024 15:36:57 +0000
Message-ID: <E1rwkrg-002MJY-Nv@gemulon.postgresql.org> (raw)

Stabilize test of BRIN parallel create

The test for parallel create of BRIN indexes added by commit 8225c2fd40
happens to be unstable - a background transaction (e.g. auto-analyze)
may hold back global xmin for the initial VACUUM / CREATE INDEX. If the
cleanup happens before the next CREATE INDEX, the indexes will not be
exactly the same.

This is the same issue as e2933a6e11, so fix it the same way by making
the table TEMPORARY, which uses an up-to-date cutoff xmin that is not
held back by other processes.

Reported by Alexander Lakhin, who also suggested the fix.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/b58901cd-a7cc-29c6-e2b1-e3d7317c3c69@gmail.com
Discussion: https://postgr.es/m/2892135.1668976646@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4d916dd876c3d9a4ceff5a0c54c5c58a0d1052e3

Modified Files
--------------
contrib/pageinspect/expected/brin.out | 2 +-
contrib/pageinspect/sql/brin.sql      | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1rwkrg-002MJY-Nv@gemulon.postgresql.org>
Permalink:  ../E1rwkrg-002MJY-Nv@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rwkrg-002MJY-Nv@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Stabilize test of BRIN parallel create
  In-Reply-To: <E1rwkrg-002MJY-Nv@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox