pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Make handling of INTERVAL DAY TO MINUTE and INTERVAL DAY TO
2+ messages / 2 participants
[nested] [flat]
* pgsql: Make handling of INTERVAL DAY TO MINUTE and INTERVAL DAY TO
@ 2009-06-10 05:05 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: tgl@postgresql.org @ 2009-06-10 05:05 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Make handling of INTERVAL DAY TO MINUTE and INTERVAL DAY TO SECOND input
more consistent with other cases, by having an unlabeled integer field
be treated as a number of minutes or seconds respectively. These cases
are outside the spec (which insists on full "dd hh:mm" or "dd hh:mm:ss"
input respectively), so it's not much help to us in deciding what to do.
But with this change, it's uniformly the case that an unlabeled integer
will be considered as being a number of the interval's rightmost field.
The change also takes us back to the 8.3 behavior of throwing error
for certain ambiguous inputs such as INTERVAL '1 2' DAY TO MINUTE.
Per recent discussion.
Modified Files:
--------------
pgsql/src/backend/utils/adt:
datetime.c (r1.206 -> r1.207)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/datetime.c?r1=1.206&r2=1.20...)
pgsql/src/test/regress/expected:
interval.out (r1.28 -> r1.29)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/interval.out?r1=1.28&r2...)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Post review fixes for test_json_parser test module
@ 2024-04-23 19:33 Andrew Dunstan <andrew@dunslane.net>
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Dunstan @ 2024-04-23 19:33 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Post review fixes for test_json_parser test module
. Add missing copytight notices
. improve code coverage
. put work files in a temp directory in the standard location
. improve error checking in C code
. indent perl files with perltidy
. add some comments
per comments from Michael Paquier
Discussion: https://postgr.es/m/ZiC3-cdFys4-6xSk@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ba3e6e2bca97df14920375b0a1ebf4eab95b78b5
Modified Files
--------------
.../t/001_test_json_parser_incremental.pl | 15 +++-
src/test/modules/test_json_parser/t/002_inline.pl | 93 ++++++++++++++++------
.../test_json_parser/t/003_test_semantic.pl | 15 +++-
.../test_json_parser/t/004_test_parser_perf.pl | 18 +++--
.../test_json_parser_incremental.c | 25 ++++--
.../test_json_parser/test_json_parser_perf.c | 13 ++-
src/test/modules/test_json_parser/tiny.json | 1 +
src/test/modules/test_json_parser/tiny.out | 1 +
8 files changed, 133 insertions(+), 48 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-04-23 19:33 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-10 05:05 pgsql: Make handling of INTERVAL DAY TO MINUTE and INTERVAL DAY TO Tom Lane <tgl@postgresql.org>
2024-04-23 19:33 pgsql: Post review fixes for test_json_parser test module Andrew Dunstan <andrew@dunslane.net>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox