pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Remove --disable-spinlocks.
3+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2024-07-30 71d6c4b966 Remove useless member of BackendParameters.
* pgsql: Remove --disable-spinlocks.
@ 2024-07-30 11:03 Thomas Munro <tmunro@postgresql.org>
2024-07-30 11:09 ` Re: pgsql: Remove --disable-spinlocks. Heikki Linnakangas <hlinnaka@iki.fi>
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Munro @ 2024-07-30 11:03 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove --disable-spinlocks.
A later change will require atomic support, so it wouldn't make sense
for a hypothetical new system not to be able to implement spinlocks.
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> (concept, not the patch)
Reviewed-by: Andres Freund <andres@anarazel.de> (concept, not the patch)
Discussion: https://postgr.es/m/3351991.1697728588%40sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e25626677f8076eb3ce94586136c5464ee154381
Modified Files
--------------
configure | 40 -------
configure.ac | 13 ---
doc/src/sgml/installation.sgml | 37 +------
meson.build | 6 --
src/backend/port/atomics.c | 26 -----
src/backend/port/posix_sema.c | 3 +-
src/backend/port/sysv_sema.c | 3 +-
src/backend/postmaster/launch_backend.c | 8 --
src/backend/storage/ipc/ipci.c | 10 --
src/backend/storage/lmgr/Makefile | 1 -
src/backend/storage/lmgr/meson.build | 1 -
src/backend/storage/lmgr/s_lock.c | 2 +-
src/backend/storage/lmgr/spin.c | 180 --------------------------------
src/include/pg_config.h.in | 3 -
src/include/pg_config_manual.h | 15 ---
src/include/port/atomics.h | 4 +-
src/include/port/atomics/fallback.h | 4 +-
src/include/storage/s_lock.h | 39 +------
src/include/storage/spin.h | 18 +---
src/test/regress/regress.c | 86 ---------------
20 files changed, 13 insertions(+), 486 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Remove --disable-spinlocks.
2024-07-30 11:03 pgsql: Remove --disable-spinlocks. Thomas Munro <tmunro@postgresql.org>
@ 2024-07-30 11:09 ` Heikki Linnakangas <hlinnaka@iki.fi>
2024-07-30 11:24 ` Re: pgsql: Remove --disable-spinlocks. Thomas Munro <thomas.munro@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Heikki Linnakangas @ 2024-07-30 11:09 UTC (permalink / raw)
To: Thomas Munro <tmunro@postgresql.org>; pgsql-committers@lists.postgresql.org
On 30/07/2024 14:03, Thomas Munro wrote:
> Remove --disable-spinlocks.
Sorry, spotted this only now:
> --- a/src/backend/postmaster/launch_backend.c
> +++ b/src/backend/postmaster/launch_backend.c
> @@ -108,9 +108,7 @@ typedef struct
> #ifdef USE_INJECTION_POINTS
> struct InjectionPointsCtl *ActiveInjectionPoints;
> #endif
> -#ifndef HAVE_SPINLOCKS
> PGSemaphore *SpinlockSemaArray;
> -#endif
> int NamedLWLockTrancheRequests;
> NamedLWLockTranche *NamedLWLockTrancheArray;
> LWLockPadded *MainLWLockArray;
The SpinLockSemaArray field should be completely completely, nut just
the #ifndef guard around it.
--
Heikki Linnakangas
Neon (https://neon.tech)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Remove --disable-spinlocks.
2024-07-30 11:03 pgsql: Remove --disable-spinlocks. Thomas Munro <tmunro@postgresql.org>
2024-07-30 11:09 ` Re: pgsql: Remove --disable-spinlocks. Heikki Linnakangas <hlinnaka@iki.fi>
@ 2024-07-30 11:24 ` Thomas Munro <thomas.munro@gmail.com>
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Munro @ 2024-07-30 11:24 UTC (permalink / raw)
To: Heikki Linnakangas <hlinnaka@iki.fi>; +Cc: Thomas Munro <tmunro@postgresql.org>; pgsql-committers@lists.postgresql.org
On Tue, Jul 30, 2024 at 11:09 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> The SpinLockSemaArray field should be completely completely, nut just
> the #ifndef guard around it.
Looks like I had that right in the first version, but got confused
while rebasing over a conflict. Fixed, thanks!
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-07-30 11:24 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-07-30 11:03 pgsql: Remove --disable-spinlocks. Thomas Munro <tmunro@postgresql.org>
2024-07-30 11:09 ` Heikki Linnakangas <hlinnaka@iki.fi>
2024-07-30 11:24 ` Thomas Munro <thomas.munro@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox