public inbox for [email protected]  
help / color / mirror / Atom feed
pgsql: Fix ALTER TABLE error message
6+ messages / 1 participants
[nested] [flat]

* pgsql: Fix ALTER TABLE error message
@ 2025-03-04 19:09 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 6+ messages in thread

From: Álvaro Herrera @ 2025-03-04 19:09 UTC (permalink / raw)
  To: [email protected]

Fix ALTER TABLE error message

This bogus error message was introduced in 2013 by commit f177cbfe676d,
because of misunderstanding the processCASbits() API; at the time, no
test cases were added that would be affected by this change.  Only in
ca87c415e2fc was one added (along with a couple of typos), with an XXX
note that the error message was bogus.  Fix the whole, add some test
cases.

Backpatch all the way back.

Reviewed-by: Nathan Bossart <[email protected]>
Discussion: https://postgr.es/m/[email protected]

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0f354e0805ed5df05e02f60c6998a7b9df14b4b6

Modified Files
--------------
src/backend/parser/gram.y                 | 2 +-
src/test/regress/expected/foreign_key.out | 6 +++++-
src/test/regress/sql/foreign_key.sql      | 4 +++-
3 files changed, 9 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix ALTER TABLE error message
@ 2025-03-04 19:09 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 6+ messages in thread

From: Álvaro Herrera @ 2025-03-04 19:09 UTC (permalink / raw)
  To: [email protected]

Fix ALTER TABLE error message

This bogus error message was introduced in 2013 by commit f177cbfe676d,
because of misunderstanding the processCASbits() API; at the time, no
test cases were added that would be affected by this change.  Only in
ca87c415e2fc was one added (along with a couple of typos), with an XXX
note that the error message was bogus.  Fix the whole, add some test
cases.

Backpatch all the way back.

Reviewed-by: Nathan Bossart <[email protected]>
Discussion: https://postgr.es/m/[email protected]

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bf1e2d2db5104ce8b764f62f8a742b3fcc66e8a5

Modified Files
--------------
src/backend/parser/gram.y                 | 2 +-
src/test/regress/expected/foreign_key.out | 6 +++++-
src/test/regress/sql/foreign_key.sql      | 4 +++-
3 files changed, 9 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix ALTER TABLE error message
@ 2025-03-04 19:09 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 6+ messages in thread

From: Álvaro Herrera @ 2025-03-04 19:09 UTC (permalink / raw)
  To: [email protected]

Fix ALTER TABLE error message

This bogus error message was introduced in 2013 by commit f177cbfe676d,
because of misunderstanding the processCASbits() API; at the time, no
test cases were added that would be affected by this change.  Only in
ca87c415e2fc was one added (along with a couple of typos), with an XXX
note that the error message was bogus.  Fix the whole, add some test
cases.

Backpatch all the way back.

Reviewed-by: Nathan Bossart <[email protected]>
Discussion: https://postgr.es/m/[email protected]

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/931a1c0237901c68e6d57227fb1368178665c794

Modified Files
--------------
src/backend/parser/gram.y                 | 2 +-
src/test/regress/expected/foreign_key.out | 6 +++++-
src/test/regress/sql/foreign_key.sql      | 4 +++-
3 files changed, 9 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix ALTER TABLE error message
@ 2025-03-04 19:09 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 6+ messages in thread

From: Álvaro Herrera @ 2025-03-04 19:09 UTC (permalink / raw)
  To: [email protected]

Fix ALTER TABLE error message

This bogus error message was introduced in 2013 by commit f177cbfe676d,
because of misunderstanding the processCASbits() API; at the time, no
test cases were added that would be affected by this change.  Only in
ca87c415e2fc was one added (along with a couple of typos), with an XXX
note that the error message was bogus.  Fix the whole, add some test
cases.

Backpatch all the way back.

Reviewed-by: Nathan Bossart <[email protected]>
Discussion: https://postgr.es/m/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7bbc46213de9301795da90923a015070239c1fcc

Modified Files
--------------
src/backend/parser/gram.y                 |  2 +-
src/test/regress/expected/constraints.out |  7 +++----
src/test/regress/expected/foreign_key.out | 10 +++++++++-
src/test/regress/sql/constraints.sql      |  3 +--
src/test/regress/sql/foreign_key.sql      |  4 +++-
5 files changed, 17 insertions(+), 9 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix ALTER TABLE error message
@ 2025-03-04 19:09 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 6+ messages in thread

From: Álvaro Herrera @ 2025-03-04 19:09 UTC (permalink / raw)
  To: [email protected]

Fix ALTER TABLE error message

This bogus error message was introduced in 2013 by commit f177cbfe676d,
because of misunderstanding the processCASbits() API; at the time, no
test cases were added that would be affected by this change.  Only in
ca87c415e2fc was one added (along with a couple of typos), with an XXX
note that the error message was bogus.  Fix the whole, add some test
cases.

Backpatch all the way back.

Reviewed-by: Nathan Bossart <[email protected]>
Discussion: https://postgr.es/m/[email protected]

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4e026be5f15994a7036eaca172126226e053f655

Modified Files
--------------
src/backend/parser/gram.y                 | 2 +-
src/test/regress/expected/foreign_key.out | 6 +++++-
src/test/regress/sql/foreign_key.sql      | 4 +++-
3 files changed, 9 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix ALTER TABLE error message
@ 2025-03-04 19:09 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 6+ messages in thread

From: Álvaro Herrera @ 2025-03-04 19:09 UTC (permalink / raw)
  To: [email protected]

Fix ALTER TABLE error message

This bogus error message was introduced in 2013 by commit f177cbfe676d,
because of misunderstanding the processCASbits() API; at the time, no
test cases were added that would be affected by this change.  Only in
ca87c415e2fc was one added (along with a couple of typos), with an XXX
note that the error message was bogus.  Fix the whole, add some test
cases.

Backpatch all the way back.

Reviewed-by: Nathan Bossart <[email protected]>
Discussion: https://postgr.es/m/[email protected]

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9ea5fe5b6c80f9522d2d819592f796d40294d83e

Modified Files
--------------
src/backend/parser/gram.y                 | 2 +-
src/test/regress/expected/foreign_key.out | 6 +++++-
src/test/regress/sql/foreign_key.sql      | 4 +++-
3 files changed, 9 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2025-03-04 19:09 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-03-04 19:09 pgsql: Fix ALTER TABLE error message Álvaro Herrera <[email protected]>
2025-03-04 19:09 pgsql: Fix ALTER TABLE error message Álvaro Herrera <[email protected]>
2025-03-04 19:09 pgsql: Fix ALTER TABLE error message Álvaro Herrera <[email protected]>
2025-03-04 19:09 pgsql: Fix ALTER TABLE error message Álvaro Herrera <[email protected]>
2025-03-04 19:09 pgsql: Fix ALTER TABLE error message Álvaro Herrera <[email protected]>
2025-03-04 19:09 pgsql: Fix ALTER TABLE error message Álvaro Herrera <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox