From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't use double-quotes in #include's of system headers.
Date: Sun, 27 Apr 2025 00:30:52 +0000
Message-ID: <E1u8pv1-001xBa-2a@gemulon.postgresql.org> (raw)
Don't use double-quotes in #include's of system headers.
While few if any C compilers will complain about this, it's
inconsistent with our other #include's of the same headers.
There are some other questionable usages in
src/include/jit/SectionMemoryManager.h and
src/pl/plperl/plperl_system.h, but perhaps those have a
reason to be like that. I can't see that these do.
Noticed while fooling around with a script to do analysis
of our header cross-inclusions.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e8ca9ed1d260e214f02f7f5464f125fe86e55597
Modified Files
--------------
src/include/storage/pmsignal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Don't use double-quotes in #include's of system headers.
In-Reply-To: <E1u8pv1-001xBa-2a@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox