From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
Date: Wed, 02 Jul 2025 18:27:47 +0000
Message-ID: <E1uX2BO-004OUA-2t@gemulon.postgresql.org> (raw)
Fix cross-version upgrade test breakage from commit fe07100e82.
In commit fe07100e82, I renamed a couple of functions in
test_dsm_registry to make it clear what they are testing. However,
the buildfarm's cross-version upgrade tests run pg_upgrade with the
test modules installed, so this caused errors like:
ERROR: could not find function "get_val_in_shmem" in file ".../test_dsm_registry.so"
To fix, revert those renames. I could probably get away with only
un-renaming the C symbols, but I figured I'd avoid introducing
function name mismatches. Also, AFAICT the buildfarm's
cross-version upgrade tests do not run the test module tests
post-upgrade, else we'll need to properly version the extension.
Per buildfarm member crake.
Discussion: https://postgr.es/m/aGVuYUNW23tStUYs%40nathan
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0c2b7174c362d3092eb7eabf0117a8d47c64ce0e
Modified Files
--------------
.../test_dsm_registry/expected/test_dsm_registry.out | 14 +++++++-------
.../modules/test_dsm_registry/sql/test_dsm_registry.sql | 4 ++--
.../modules/test_dsm_registry/test_dsm_registry--1.0.sql | 4 ++--
src/test/modules/test_dsm_registry/test_dsm_registry.c | 8 ++++----
4 files changed, 15 insertions(+), 15 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
In-Reply-To: <E1uX2BO-004OUA-2t@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox