From: Nathan Bossart <nathandbossart@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Nathan Bossart <nathan@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
Date: Wed, 2 Jul 2025 14:44:42 -0500
Message-ID: <aGWMKkLhTmCnCO1N@nathan> (raw)
In-Reply-To: <597c8ce0-12e5-4522-b8d7-eff378720085@dunslane.net>
References: <E1uX2BO-004OUA-2t@gemulon.postgresql.org>
<597c8ce0-12e5-4522-b8d7-eff378720085@dunslane.net>
On Wed, Jul 02, 2025 at 03:43:02PM -0400, Andrew Dunstan wrote:
> On 2025-07-02 We 2:27 PM, Nathan Bossart wrote:
>> To fix, revert those renames. I could probably get away with only
>> un-renaming the C symbols, but I figured I'd avoid introducing
>> function name mismatches. Also, AFAICT the buildfarm's
>> cross-version upgrade tests do not run the test module tests
>> post-upgrade, else we'll need to properly version the extension.
>
> It doesn't really run any sanity checks at all other than amchecks.. It just
> compares the pre- and post- upgrade dumps (with suitable modifications).
>
> So far that seems to have been enough.
Thanks for confirming.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nathandbossart@gmail.com, andrew@dunslane.net, nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82.
In-Reply-To: <aGWMKkLhTmCnCO1N@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox