pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: injection_points: Add injection_points_list()
3+ messages / 2 participants
[nested] [flat]
* pgsql: injection_points: Add injection_points_list()
@ 2025-07-10 01:13 Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 3+ messages in thread
From: Michael Paquier @ 2025-07-10 01:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
injection_points: Add injection_points_list()
This function can be used to retrieve the information about all the
injection points attached to a cluster, providing coverage for
InjectionPointList() introduced in 7b2eb72b1b8c.
The original proposal turned around a system function, but that would
not be backpatchable to stable branches. It was also a bit weird to
have a system function that fails depending on if the build allows
injection points or not.
Reviewed-by: Aleksander Alekseev <aleksander@timescale.com>
Reviewed-by: Rahila Syed <rahilasyed90@gmail.com>
Discussion: https://postgr.es/m/Z_xYkA21KyLEHvWR@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4eca711bc991954613261b7a314b1e8f5963815c
Modified Files
--------------
.../injection_points/expected/injection_points.out | 16 +++++++++
.../injection_points/injection_points--1.0.sql | 12 +++++++
.../modules/injection_points/injection_points.c | 39 ++++++++++++++++++++++
.../injection_points/sql/injection_points.sql | 7 ++++
4 files changed, 74 insertions(+)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: injection_points: Add injection_points_list()
@ 2025-07-10 10:24 Aleksander Alekseev <aleksander@tigerdata.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 3+ messages in thread
From: Aleksander Alekseev @ 2025-07-10 10:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org; +Cc: Michael Paquier <michael@paquier.xyz>
Hi Michael,
> injection_points: Add injection_points_list()
>
> This function can be used to retrieve the information about all the
> injection points attached to a cluster, providing coverage for
> InjectionPointList() introduced in 7b2eb72b1b8c.
>
> The original proposal turned around a system function, but that would
> not be backpatchable to stable branches. It was also a bit weird to
> have a system function that fails depending on if the build allows
> injection points or not.
In injection_points_list() isn't `memset(values, 0, sizeof(values))`
redundant? Also perhaps we want to pfree inj_points.
These are minor issues of course.
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: injection_points: Add injection_points_list()
@ 2025-07-13 02:21 Michael Paquier <michael@paquier.xyz>
parent: Aleksander Alekseev <aleksander@tigerdata.com>
0 siblings, 0 replies; 3+ messages in thread
From: Michael Paquier @ 2025-07-13 02:21 UTC (permalink / raw)
To: Aleksander Alekseev <aleksander@tigerdata.com>; +Cc: pgsql-committers@lists.postgresql.org
On Thu, Jul 10, 2025 at 01:24:48PM +0300, Aleksander Alekseev wrote:
> In injection_points_list() isn't `memset(values, 0, sizeof(values))`
> redundant?
Yes, I'm just finding this to be a cleaner practice.
> Also perhaps we want to pfree inj_points.
This is freed with the memory context of the function, so any way is
fine IMO.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-07-13 02:21 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-07-10 01:13 pgsql: injection_points: Add injection_points_list() Michael Paquier <michael@paquier.xyz>
2025-07-10 10:24 ` Aleksander Alekseev <aleksander@tigerdata.com>
2025-07-13 02:21 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox