From: Michael Paquier <michael@paquier.xyz>
To: Aleksander Alekseev <aleksander@tigerdata.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: injection_points: Add injection_points_list()
Date: Sun, 13 Jul 2025 11:21:20 +0900
Message-ID: <aHMYILre3-FgticE@paquier.xyz> (raw)
In-Reply-To: <CAJ7c6TOVA-DPdK9pL5OGnap1rvj+y-hgYwgTMmpjUQvdrGNThA@mail.gmail.com>
References: <E1uZfqe-005Vn8-08@gemulon.postgresql.org>
<CAJ7c6TOVA-DPdK9pL5OGnap1rvj+y-hgYwgTMmpjUQvdrGNThA@mail.gmail.com>
On Thu, Jul 10, 2025 at 01:24:48PM +0300, Aleksander Alekseev wrote:
> In injection_points_list() isn't `memset(values, 0, sizeof(values))`
> redundant?
Yes, I'm just finding this to be a cleaner practice.
> Also perhaps we want to pfree inj_points.
This is freed with the memory context of the function, so any way is
fine IMO.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, aleksander@tigerdata.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: injection_points: Add injection_points_list()
In-Reply-To: <aHMYILre3-FgticE@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox