public inbox for [email protected]help / color / mirror / Atom feed
pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. 5+ messages / 1 participants [nested] [flat]
* pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. @ 2026-02-25 16:57 Tom Lane <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2026-02-25 16:57 UTC (permalink / raw) To: [email protected] Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Although clang claims to be compatible with gcc's printf format archetypes, this appears to be a falsehood: it likes __syslog__ (which gcc does not, on most platforms) and doesn't accept gnu_printf. This means that if you try to use gcc with clang++ or clang with g++, you get compiler warnings when compiling printf-like calls in our C++ code. This has been true for quite awhile, but it's gotten more annoying with the recent appearance of several buildfarm members that are configured like this. To fix, run separate probes for the format archetype to use with the C and C++ compilers, and conditionally define PG_PRINTF_ATTRIBUTE depending on __cplusplus. (We could alternatively insist that you not mix-and-match C and C++ compilers; but if the case works otherwise, this is a poor reason to insist on that.) This commit back-patches 0909380e4 into supported branches. Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14-18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/753d5eee46d1d9c2c7f28192ae62d5da9d7d1408 Modified Files -------------- config/c-compiler.m4 | 46 +++++++++++++++++++--- configure | 96 ++++++++++++++++++++++++++++++++++++++++++++-- configure.ac | 1 + meson.build | 17 +++++++- src/include/c.h | 10 +++++ src/include/pg_config.h.in | 11 ++++-- 6 files changed, 169 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. @ 2026-02-25 16:57 Tom Lane <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2026-02-25 16:57 UTC (permalink / raw) To: [email protected] Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Although clang claims to be compatible with gcc's printf format archetypes, this appears to be a falsehood: it likes __syslog__ (which gcc does not, on most platforms) and doesn't accept gnu_printf. This means that if you try to use gcc with clang++ or clang with g++, you get compiler warnings when compiling printf-like calls in our C++ code. This has been true for quite awhile, but it's gotten more annoying with the recent appearance of several buildfarm members that are configured like this. To fix, run separate probes for the format archetype to use with the C and C++ compilers, and conditionally define PG_PRINTF_ATTRIBUTE depending on __cplusplus. (We could alternatively insist that you not mix-and-match C and C++ compilers; but if the case works otherwise, this is a poor reason to insist on that.) This commit back-patches 0909380e4 into supported branches. Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14-18 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ae40bb835135a8ebdba5f32f3470ddad20e78b85 Modified Files -------------- config/c-compiler.m4 | 46 +++++++++++++++++++--- configure | 96 ++++++++++++++++++++++++++++++++++++++++++++-- configure.ac | 1 + meson.build | 17 +++++++- src/include/c.h | 10 +++++ src/include/pg_config.h.in | 11 ++++-- 6 files changed, 169 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. @ 2026-02-25 16:57 Tom Lane <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2026-02-25 16:57 UTC (permalink / raw) To: [email protected] Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Although clang claims to be compatible with gcc's printf format archetypes, this appears to be a falsehood: it likes __syslog__ (which gcc does not, on most platforms) and doesn't accept gnu_printf. This means that if you try to use gcc with clang++ or clang with g++, you get compiler warnings when compiling printf-like calls in our C++ code. This has been true for quite awhile, but it's gotten more annoying with the recent appearance of several buildfarm members that are configured like this. To fix, run separate probes for the format archetype to use with the C and C++ compilers, and conditionally define PG_PRINTF_ATTRIBUTE depending on __cplusplus. (We could alternatively insist that you not mix-and-match C and C++ compilers; but if the case works otherwise, this is a poor reason to insist on that.) This commit back-patches 0909380e4 into supported branches. Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14-18 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1d97e47883e0b45da22a42ab620762cc8022aa37 Modified Files -------------- config/c-compiler.m4 | 46 +++++++++++++++++++--- configure | 96 ++++++++++++++++++++++++++++++++++++++++++++-- configure.ac | 1 + meson.build | 17 +++++++- src/include/c.h | 10 +++++ src/include/pg_config.h.in | 11 ++++-- 6 files changed, 169 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. @ 2026-02-25 16:57 Tom Lane <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2026-02-25 16:57 UTC (permalink / raw) To: [email protected] Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Although clang claims to be compatible with gcc's printf format archetypes, this appears to be a falsehood: it likes __syslog__ (which gcc does not, on most platforms) and doesn't accept gnu_printf. This means that if you try to use gcc with clang++ or clang with g++, you get compiler warnings when compiling printf-like calls in our C++ code. This has been true for quite awhile, but it's gotten more annoying with the recent appearance of several buildfarm members that are configured like this. To fix, run separate probes for the format archetype to use with the C and C++ compilers, and conditionally define PG_PRINTF_ATTRIBUTE depending on __cplusplus. (We could alternatively insist that you not mix-and-match C and C++ compilers; but if the case works otherwise, this is a poor reason to insist on that.) This commit back-patches 0909380e4 into supported branches. Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14-18 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7e788a585a6c29b12fcb53a313ac5c4d080c36e8 Modified Files -------------- config/c-compiler.m4 | 46 +++++++++++++++++++--- configure | 96 ++++++++++++++++++++++++++++++++++++++++++++-- configure.ac | 1 + src/include/c.h | 10 +++++ src/include/pg_config.h.in | 11 ++++-- 5 files changed, 153 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. @ 2026-02-25 16:57 Tom Lane <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2026-02-25 16:57 UTC (permalink / raw) To: [email protected] Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Although clang claims to be compatible with gcc's printf format archetypes, this appears to be a falsehood: it likes __syslog__ (which gcc does not, on most platforms) and doesn't accept gnu_printf. This means that if you try to use gcc with clang++ or clang with g++, you get compiler warnings when compiling printf-like calls in our C++ code. This has been true for quite awhile, but it's gotten more annoying with the recent appearance of several buildfarm members that are configured like this. To fix, run separate probes for the format archetype to use with the C and C++ compilers, and conditionally define PG_PRINTF_ATTRIBUTE depending on __cplusplus. (We could alternatively insist that you not mix-and-match C and C++ compilers; but if the case works otherwise, this is a poor reason to insist on that.) This commit back-patches 0909380e4 into supported branches. Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14-18 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ff9bd96754f171a9277a13de7e0dea7349b57278 Modified Files -------------- config/c-compiler.m4 | 46 +++++++++++++++++++--- configure | 96 ++++++++++++++++++++++++++++++++++++++++++++-- configure.ac | 1 + src/include/c.h | 10 +++++ src/include/pg_config.h.in | 11 ++++-- 5 files changed, 153 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-02-25 16:57 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-02-25 16:57 pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Tom Lane <[email protected]> 2026-02-25 16:57 pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Tom Lane <[email protected]> 2026-02-25 16:57 pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Tom Lane <[email protected]> 2026-02-25 16:57 pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Tom Lane <[email protected]> 2026-02-25 16:57 pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Tom Lane <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox