From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clarify logic in CreateSubscription().
Date: Sat, 15 Aug 2026 16:54:30 +0000
Message-ID: <E1wvHeP-00000000hBe-09Or@gemulon.postgresql.org> (raw)
Clarify logic in CreateSubscription().
No bug found in previous code, but it unnecessarily relied on grammar
rules. Per complaint from Coverity.
Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/1787286.1786328153@sss.pgh.pa.us
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3d00537feb565c410baf41bb301eee338e4b2317
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Clarify logic in CreateSubscription().
In-Reply-To: <E1wvHeP-00000000hBe-09Or@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox