pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Improve error message for checksum failures in pgstat_database.c 3+ messages / 2 participants [nested] [flat]
* pgsql: Improve error message for checksum failures in pgstat_database.c @ 2026-02-13 03:18 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2026-02-13 03:18 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve error message for checksum failures in pgstat_database.c This log message was referring to conflicts, but it is about checksum failures. The log message improved in this commit should never show up, due to the fact that pgstat_prepare_report_checksum_failure() should always be called before pgstat_report_checksum_failures_in_db(), with a stats entry already created in the pgstats shared hash table. The three code paths able to report database-level checksum failures follow already this requirement. Oversight in b96d3c389755. Author: Wang Peng <215722532@qq.com> Discussion: https://postgr.es/m/tencent_9B6CD6D9D34AE28CDEADEC6188DB3BA1FE07@qq.com Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/775fc014156bdfa6938ef02dce3d85364b1bd220 Modified Files -------------- src/backend/utils/activity/pgstat_database.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Improve error message for checksum failures in pgstat_database.c @ 2026-02-13 03:18 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2026-02-13 03:18 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve error message for checksum failures in pgstat_database.c This log message was referring to conflicts, but it is about checksum failures. The log message improved in this commit should never show up, due to the fact that pgstat_prepare_report_checksum_failure() should always be called before pgstat_report_checksum_failures_in_db(), with a stats entry already created in the pgstats shared hash table. The three code paths able to report database-level checksum failures follow already this requirement. Oversight in b96d3c389755. Author: Wang Peng <215722532@qq.com> Discussion: https://postgr.es/m/tencent_9B6CD6D9D34AE28CDEADEC6188DB3BA1FE07@qq.com Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5b0e0c3d03ebbc09ad2534cfb26aa440b21c7ba0 Modified Files -------------- src/backend/utils/activity/pgstat_database.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Improve error message for checksum state in pg_upgrade @ 2026-09-14 13:34 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Daniel Gustafsson @ 2026-09-14 13:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve error message for checksum state in pg_upgrade When attempting to upgrade a cluster which is an inprogress state, the same error message was used regardless of which state it was. Fix by using different error messages for the different inprogress states. Found by Noah using AI assisted review with Claude. Backpatch to v19 where the online checksums feature was introduced. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/E15AC050-C4B5-488D-BB2D-3C7AC9F89EA8@yesql.se Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/9a45131b7cf3b573d1b15a093a3cc80869814cbe Modified Files -------------- src/bin/pg_upgrade/controldata.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-09-14 13:34 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-02-13 03:18 pgsql: Improve error message for checksum failures in pgstat_database.c Michael Paquier <michael@paquier.xyz> 2026-02-13 03:18 pgsql: Improve error message for checksum failures in pgstat_database.c Michael Paquier <michael@paquier.xyz> 2026-09-14 13:34 pgsql: Improve error message for checksum state in pg_upgrade Daniel Gustafsson <dgustafsson@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox