From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Add support for coordinating record typmods among parallel worke
Date: Thu, 14 Sep 2017 21:11:58 -0700
Message-ID: <EE83DBB6-815E-4D06-81D8-5A56B9604C09@anarazel.de> (raw)
In-Reply-To: <CAEepm=08r6ssWnM7wOAN=omz=s9DHujsJjJY6SN_PTHayPR0hw@mail.gmail.com>
References: <E1dsguX-00056N-9x@gemulon.postgresql.org>
<13971.1505445491@sss.pgh.pa.us>
<CAEepm=08r6ssWnM7wOAN=omz=s9DHujsJjJY6SN_PTHayPR0hw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
On September 14, 2017 8:38:09 PM PDT, Thomas Munro <thomas.munro@enterprisedb.com> wrote:
>On Fri, Sep 15, 2017 at 3:18 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Andres Freund <andres@anarazel.de> writes:
>>> Add support for coordinating record typmods among parallel workers.
>>
>> Buildfarm not happy ...
>
>My compiler, C++ and more recent C standards are OK with identical
>redefinition of a typedef like that, but not the older standards or
>those particular compilers. D'oh. (I should figure out how to make
>my automatic patch tester this fussy). I think we should probably
>just do this:
>
>diff --git a/src/include/access/session.h
>b/src/include/access/session.h
>index 8376dc53127..910a9815d78 100644
>--- a/src/include/access/session.h
>+++ b/src/include/access/session.h
>@@ -13,9 +13,7 @@
> #define SESSION_H
>
> #include "lib/dshash.h"
>-
>-/* Defined in typcache.c */
>-typedef struct SharedRecordTypmodRegistry SharedRecordTypmodRegistry;
>+#include "utils/typcache.h"
>
> /*
>* A struct encapsulating some elements of a user's session. For now
>this
Sorry for missing that during review - unfortunately I don't have a computer with me now - so I won't get around to this till tomorrow...
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, thomas.munro@enterprisedb.com, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Add support for coordinating record typmods among parallel worke
In-Reply-To: <EE83DBB6-815E-4D06-81D8-5A56B9604C09@anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox