pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
Date: Sun, 12 Feb 2023 12:12:55 -0800
Message-ID: <F9E5BF47-8ADE-40EE-912C-E1DC6C19B2BF@anarazel.de> (raw)
In-Reply-To: <E1pRGkY-000mgl-AI@gemulon.postgresql.org>
References: <E1pRGkY-000mgl-AI@gemulon.postgresql.org>

Hi, 

On February 12, 2023 10:06:55 AM PST, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Make pg_bsd_indent's .h files inclusion-order-safe.
>
>As-is, they failed headerscheck.  Per buildfarm.

Cfbot didn't catch this, because it only triggered a warning, not a failure.  We probably should add -Werror?


Greetings,

Andres 
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.





view thread (7+ messages)  latest in thread

Message-ID: <F9E5BF47-8ADE-40EE-912C-E1DC6C19B2BF@anarazel.de>
Permalink:  ../F9E5BF47-8ADE-40EE-912C-E1DC6C19B2BF@anarazel.de/
Also on:    postgresql.org/message-id/F9E5BF47-8ADE-40EE-912C-E1DC6C19B2BF@anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
  In-Reply-To: <F9E5BF47-8ADE-40EE-912C-E1DC6C19B2BF@anarazel.de>
  References: <E1pRGkY-000mgl-AI@gemulon.postgresql.org> <F9E5BF47-8ADE-40EE-912C-E1DC6C19B2BF@anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox