pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
Date: Sun, 12 Feb 2023 17:30:50 -0500
Message-ID: <969565.1676241050@sss.pgh.pa.us> (raw)
In-Reply-To: <20230212222141.hsrabsjgzksfuq77@awork3.anarazel.de>
References: <E1pRGkY-000mgl-AI@gemulon.postgresql.org>
	<F9E5BF47-8ADE-40EE-912C-E1DC6C19B2BF@anarazel.de>
	<960944.1676236268@sss.pgh.pa.us>
	<3A6C72BD-50D3-4B8B-B614-CDE83E7E1FBC@anarazel.de>
	<962481.1676237128@sss.pgh.pa.us>
	<20230212222141.hsrabsjgzksfuq77@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> Obviously that approach could be re-implemented for CI, but givent that it
> additionally is somewhat required to make use of headerscheck/cpluspluscheck
> locally, it feels better to solve it in headerscheck. And the easiest way for
> that seems to be -Werror?

Agreed --- although right now, headerscheck goes out of its way to be
agnostic about what compiler and cflags are used.  Having it assume
that -Werror will work seems a bit ugly.  Not sure that it's a problem
in practice though.

(BTW, we'll have to fix these scripts sometime to work in non-Make
builds.)

			regards, tom lane





view thread (7+ messages)

Message-ID: <969565.1676241050@sss.pgh.pa.us>
Permalink:  ../969565.1676241050@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/969565.1676241050@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
  In-Reply-To: <969565.1676241050@sss.pgh.pa.us>
  References: <E1pRGkY-000mgl-AI@gemulon.postgresql.org> <F9E5BF47-8ADE-40EE-912C-E1DC6C19B2BF@anarazel.de> <960944.1676236268@sss.pgh.pa.us> <3A6C72BD-50D3-4B8B-B614-CDE83E7E1FBC@anarazel.de> <962481.1676237128@sss.pgh.pa.us> <20230212222141.hsrabsjgzksfuq77@awork3.anarazel.de> <969565.1676241050@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox