From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module
Date: Thu, 26 Jan 2023 07:53:25 +0900
Message-ID: <Y9Gy5Qa5ARuf3xir@paquier.xyz> (raw)
In-Reply-To: <20230125224118.GB1164580@nathanxps13>
References: <E1pKYTE-005MZS-WB@gemulon.postgresql.org>
<CA+TgmoYG5uGOp7DGFT5gzC1kKFWGjkLSj_wOQxGhfMcvVEiKGA@mail.gmail.com>
<20230125181750.GC1098626@nathanxps13>
<CA+TgmoY4WTkFNHZjSSjjjOSUyjHzatwMp+DVWK3W-A=h5+AQzQ@mail.gmail.com>
<20230125215801.zhqe7t67uhdxai5g@awork3.anarazel.de>
<20230125224118.GB1164580@nathanxps13>
On Wed, Jan 25, 2023 at 02:41:18PM -0800, Nathan Bossart wrote:
> This is my preference. If Michael and Robert are okay with it, I think
> this is what we should do. Else, I'll create separate basic_archive and
> basic_restore modules.
Grouping both things into the same module has the advantage to ease
the configuration, at least in the example, where the archive
directory GUC can be used for both paths.
Regarding the renaming, I pushed for that. There's little love for it
as far as I can see, so will revert accordingly. Keeping
basic_archive as name for the module while it includes recovery is
fine by me.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, nathandbossart@gmail.com, andres@anarazel.de, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Rename contrib module basic_archive to basic_wal_module
In-Reply-To: <Y9Gy5Qa5ARuf3xir@paquier.xyz>
References: <E1pKYTE-005MZS-WB@gemulon.postgresql.org> <CA+TgmoYG5uGOp7DGFT5gzC1kKFWGjkLSj_wOQxGhfMcvVEiKGA@mail.gmail.com> <20230125181750.GC1098626@nathanxps13> <CA+TgmoY4WTkFNHZjSSjjjOSUyjHzatwMp+DVWK3W-A=h5+AQzQ@mail.gmail.com> <20230125215801.zhqe7t67uhdxai5g@awork3.anarazel.de> <20230125224118.GB1164580@nathanxps13> <Y9Gy5Qa5ARuf3xir@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox