From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
Date: Fri, 17 Sep 2021 08:08:44 +0900
Message-ID: <YUPOfPqqbvuZeouS@paquier.xyz> (raw)
In-Reply-To: <1252480.1631829409@sss.pgh.pa.us>
References: <E1mQglq-0007xB-Jw@gemulon.postgresql.org>
<1252480.1631829409@sss.pgh.pa.us>
On Thu, Sep 16, 2021 at 05:56:49PM -0400, Tom Lane wrote:
> Test case for this seems to have newline-related issues on Windows.
Thanks. I missed it.
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2021-09-16%2018%3A36%3A14
>
> # Failed test 'data_checksums=on is reported on an offline cluster stdout /(?^:^on$)/'
> # at t/002_actions.pl line 184.
> # 'on
> # '
> # doesn't match '(?^:^on$)'
The regex should match AFAIK, and that worked in my own WIN32,
non-Msys, environment.
I see the business in PostgresNode::command_like_safe to work around
such a case like that in pg_ctl (efd7f8e), very similar to what I am
doing here so an extra chomp() should address this issue. Shouldn't
we try in the long-term to make the command_checks_* routines use
temporary files rather than the raw outputs if these are not reliable,
by the way? Adding Andrew in CC about that.
I am not completely sure what's going on here yet, so I'll just switch
the test to be skipped when Msys is involved for now. That should be
enough to bring back those machines to green.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, andrew@dunslane.net
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
In-Reply-To: <YUPOfPqqbvuZeouS@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox