From: Michael Paquier <michael@paquier.xyz>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: pgsql: Add more $Test::Builder::Level in the TAP tests
Date: Thu, 14 Oct 2021 12:51:11 +0900
Message-ID: <YWepL/jDBoidu/Ek@paquier.xyz> (raw)
In-Reply-To: <CAH2-Wzn8ftvcDPwomn+y04JJzbT=TG7TN=QsmSEATUOW-ZuvQQ@mail.gmail.com>
References: <E1ma7Ll-0006i4-3r@gemulon.postgresql.org>
<CAH2-Wzn8ftvcDPwomn+y04JJzbT=TG7TN=QsmSEATUOW-ZuvQQ@mail.gmail.com>
On Wed, Oct 13, 2021 at 08:14:20PM -0700, Peter Geoghegan wrote:
> On Mon, Oct 11, 2021 at 7:17 PM Michael Paquier <michael@paquier.xyz> wrote:
> > Add more $Test::Builder::Level in the TAP tests
>
> I saw an issue just now that I suspect is linked with this commit. I
> ran my parallel "make check-world" recipe, and saw this failure:
This commit has not touched 001_basic.pl, nor does it touch any of the
modules we have in src/test/perl/, so that's unrelated. In the worst
case, what you would get after this commit is a better report by
incrementing the level stack.
The problem is that this test script assumes that it is fine to not
use -X/--no-psqlrc in the commands of psql run, making this test prone
to fail depending on the local setup. Please note that we pass down
-X through PostgresNode::psql, to keep the tests isolated from the
external world, so this could be fixed either by using -X but I think
that it would be better to switch to psql() with a comparison done to
the outputs of stdout, stderr and the error code returned. The
failure can be reproduced easily once one adds some junk in their
local psqlrc.
Adding Peter E in CC, as the author of c0280bc & co.
> # Failed test 'handling of unexpected PQresultStatus: matches'
> # at t/001_basic.pl line 43.
> # 'psql:/home/pg/.psqlrc:56: ERROR: syntax error
> # psql:/home/pg/.psqlrc:57: ERROR: syntax error
> # LOG: received replication command: START_REPLICATION 0/0
> # unexpected PQresultStatus: 8
> # '
You may also want to fix your local .psqlrc, while on it.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pg@bowt.ie, peter.eisentraut@enterprisedb.com
Subject: Re: pgsql: Add more $Test::Builder::Level in the TAP tests
In-Reply-To: <YWepL/jDBoidu/Ek@paquier.xyz>
References: <E1ma7Ll-0006i4-3r@gemulon.postgresql.org> <CAH2-Wzn8ftvcDPwomn+y04JJzbT=TG7TN=QsmSEATUOW-ZuvQQ@mail.gmail.com> <YWepL/jDBoidu/Ek@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox