pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add various assertions to heap pruning code.
Date: Fri, 5 Nov 2021 15:48:25 +0900
Message-ID: <YYTTuYykpVXEfnOr@paquier.xyz> (raw)
In-Reply-To: <E1miofr-0003a8-8p@gemulon.postgresql.org>
References: <E1miofr-0003a8-8p@gemulon.postgresql.org>

Hi Peter,

On Fri, Nov 05, 2021 at 02:09:47AM +0000, Peter Geoghegan wrote:
> Add various assertions to heap pruning code.
> 
> These assertions document (and verify) our high level assumptions about
> how pruning can and cannot affect existing items from target heap pages.
> For example, one of the new assertions verifies that pruning does not
> set a heap-only tuple to LP_DEAD.

This generates some warnings on Windows without asserts:
pruneheap.c(847): warning C4101: 'htup' unreferenced local variable
pruneheap.c(859): warning C4101: 'tolp' unreferenced local variable

You could move those two variables within their USE_ASSERT_CHECKING
blocks, for example.

Thanks,
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (3+ messages)  latest in thread

Message-ID: <YYTTuYykpVXEfnOr@paquier.xyz>
Permalink:  ../YYTTuYykpVXEfnOr@paquier.xyz/
Also on:    postgresql.org/message-id/YYTTuYykpVXEfnOr@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pg@bowt.ie
  Subject: Re: pgsql: Add various assertions to heap pruning code.
  In-Reply-To: <YYTTuYykpVXEfnOr@paquier.xyz>
  References: <E1miofr-0003a8-8p@gemulon.postgresql.org> <YYTTuYykpVXEfnOr@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox