pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: psql: initialize comment-begin setting to a useful value by defa
Date: Thu, 2 Dec 2021 15:53:17 +0900
Message-ID: <YahtXUVtBeh+P7oL@paquier.xyz> (raw)
In-Reply-To: <E1msTLm-0007Cm-Ri@gemulon.postgresql.org>
References: <E1msTLm-0007Cm-Ri@gemulon.postgresql.org>

Hi Tom,

On Wed, Dec 01, 2021 at 05:24:58PM +0000, Tom Lane wrote:
> psql: initialize comment-begin setting to a useful value by default.
> 
> Readline's meta-# command is supposed to insert a comment marker
> at the start of the current line.  However, the default marker is
> "#" which is entirely unhelpful for SQL.  Set it to "-- " instead.
> (This setting can still be overridden in one's ~/.inputrc file,
> so this change won't affect people who have already taken steps
> to make the command useful.)

prairiedog is unhappy after this commit due to the use of
rl_variable_bind():
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2021-12-02%2005%3A29%3A32

/usr/bin/ld: Undefined symbols:
_rl_variable_bind
collect2: ld returned 1 exit status

Thanks,
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (3+ messages)  latest in thread

Message-ID: <YahtXUVtBeh+P7oL@paquier.xyz>
Permalink:  ../YahtXUVtBeh+P7oL@paquier.xyz/
Also on:    postgresql.org/message-id/YahtXUVtBeh+P7oL@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us
  Subject: Re: pgsql: psql: initialize comment-begin setting to a useful value by defa
  In-Reply-To: <YahtXUVtBeh+P7oL@paquier.xyz>
  References: <E1msTLm-0007Cm-Ri@gemulon.postgresql.org> <YahtXUVtBeh+P7oL@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox