pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.
Date: Sat, 12 Feb 2022 13:38:45 +0900
Message-ID: <Ygc51WVAFGocSu4h@paquier.xyz> (raw)
In-Reply-To: <E1nIWNg-0005L1-2v@gemulon.postgresql.org>
References: <E1nIWNg-0005L1-2v@gemulon.postgresql.org>

On Fri, Feb 11, 2022 at 01:54:36PM +0000, Robert Haas wrote:
> Add suport for server-side LZ4 base backup compression.
> 
> LZ4 compression can be a lot faster than gzip compression, so users
> may prefer it even if the compression ratio is not as good. We will
> want pg_basebackup to support LZ4 compression and decompression on the
> client side as well, and there is a pending patch for that, but it's
> by a different author, so I am committing this part separately for
> that reason.
> 
> Jeevan Ladhe, reviewed by Tushar Ahuja and by me.

copperhead seems to be unhappy here:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=copperhead&dt=2022-02-11%2021%3A52%3A48
# Running: lz4 -d -m
/home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/tmp_check/t_008_untar_primary_data/backup/server-backup/base.tar.lz4
Can't exec "lz4": No such file or directory at
/home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/../../../src/test/perl/PostgreSQL/Test/Utils.pm
line 388.
Bail out!  failed to execute command "lz4 -d -m
/home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/tmp_check/t_008_untar_primary_data/backup/server-backup/base.tar.lz4":
No such file or directory
### Stopping node "primary" using mode immediate

Perhaps you'd better check that 'decompress_program' can be executed
and skip things if the command is not around?  Note that
020_pg_receivewal.pl does an extra lz4 --version as a safety measure,
but 008_untar.pl does not.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (13+ messages)  latest in thread

Message-ID: <Ygc51WVAFGocSu4h@paquier.xyz>
Permalink:  ../Ygc51WVAFGocSu4h@paquier.xyz/
Also on:    postgresql.org/message-id/Ygc51WVAFGocSu4h@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, rhaas@postgresql.org
  Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.
  In-Reply-To: <Ygc51WVAFGocSu4h@paquier.xyz>
  References: <E1nIWNg-0005L1-2v@gemulon.postgresql.org> <Ygc51WVAFGocSu4h@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox