pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Christoph Berg <myon@debian.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
Date: Sat, 12 Feb 2022 17:31:55 +0100
Message-ID: <Ygfg+7yePes1X/A9@msg.df7cb.de> (raw)
In-Reply-To: <2280644.1644683003@sss.pgh.pa.us>
References: <E1nHbaO-0000MF-RO@gemulon.postgresql.org>
	<YgYw25OXV5men8Fj@msg.df7cb.de>
	<YgcDeben8eigBdNZ@paquier.xyz>
	<Ygd0jsxHreT1cig0@msg.df7cb.de>
	<2280644.1644683003@sss.pgh.pa.us>

Re: Tom Lane
> Christoph Berg <myon@debian.org> writes:
> > I think the "bug" here is that vanilla PG doesn't support installing
> > in FHS locations with /usr/lib and /usr/share split, hence the Debian
> > patch.
> 
> I'm confused by this statement.  An out-of-the-box installation
> produces trees under $PREFIX/lib and $PREFIX/share.  What about
> that is not FHS compliant?  And couldn't you fix it using the
> installation fine-tuning switches that configure already provides?

To support multiple major versions in parallel, we need
/usr/lib/postgresql/NN/lib and /usr/share/postgresql/NN, so it's not a
single $PREFIX. But you are correct, and ./configure supports that.

I was confusing that with this: The problem that led to the pg_config
patch years ago was that we have a /usr/bin/pg_config in
(non-major-version-dependant) libpq-dev, and
/usr/lib/postgresql/NN/bin/pg_config in the individual
postgresql-server-dev-NN packages, and iirc the /usr/bin version
didn't particularly like the other binaries being in
/usr/lib/postgresql/NN/bin/.

I guess it's time to revisit that problem now and see if it can be
solved more pretty today on our side.

Sorry for the rumbling,
Christoph





view thread (26+ messages)  latest in thread

Message-ID: <Ygfg+7yePes1X/A9@msg.df7cb.de>
Permalink:  ../Ygfg+7yePes1X%2FA9@msg.df7cb.de/
Also on:    postgresql.org/message-id/Ygfg+7yePes1X/A9@msg.df7cb.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: myon@debian.org, tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
  In-Reply-To: <Ygfg+7yePes1X/A9@msg.df7cb.de>
  References: <E1nHbaO-0000MF-RO@gemulon.postgresql.org> <YgYw25OXV5men8Fj@msg.df7cb.de> <YgcDeben8eigBdNZ@paquier.xyz> <Ygd0jsxHreT1cig0@msg.df7cb.de> <2280644.1644683003@sss.pgh.pa.us> <Ygfg+7yePes1X/A9@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox