pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Markus Wanner <markus.wanner@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]
Date: Fri, 8 Apr 2022 16:13:47 +0900
Message-ID: <Yk/gq9osXcNDoFM2@paquier.xyz> (raw)
In-Reply-To: <CA+TgmoZL_wsAEgzNx6P+zdC937ojede58Sn8OieXMmqV0khTSA@mail.gmail.com>
References: <E1nXTCX-001DGF-R0@gemulon.postgresql.org>
	<a7880f4d-1d74-582a-ada7-dad168d046d1@enterprisedb.com>
	<CA+TgmoaVwQj_nG-jPB8O=t8=h-QBoF2U+tKviv8BT8unfTEZiw@mail.gmail.com>
	<2358496.1649168259@sss.pgh.pa.us>
	<CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com>
	<Yk94Hvnrx1V00skb@paquier.xyz>
	<3535855.1649375539@sss.pgh.pa.us>
	<CA+TgmoZL_wsAEgzNx6P+zdC937ojede58Sn8OieXMmqV0khTSA@mail.gmail.com>

On Thu, Apr 07, 2022 at 10:19:35PM -0400, Robert Haas wrote:
> Yeah, that's exactly why I didn't do what Michael proposes. If we're
> going to go to this trouble to avoid changing the layout of a PGPROC,
> we must be doing that on the theory that extension code cares about
> delayChkpt. And if that is so, it seems reasonable to suppose that it
> might also want to call the associated functions.

Compatibility does not strike me as a problem with two static inline 
functions used as wrappers of their common logic.

> Honestly, I wouldn't have thought that this mattered, because I
> wouldn't have guessed that any non-core code cared about delayChkpt.
> But I would have been wrong.

That's a minor point.  If you wish to keep this code as you are
proposing, that's fine as well by me.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (23+ messages)  latest in thread

Message-ID: <Yk/gq9osXcNDoFM2@paquier.xyz>
Permalink:  ../Yk%2Fgq9osXcNDoFM2@paquier.xyz/
Also on:    postgresql.org/message-id/Yk/gq9osXcNDoFM2@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org, horikyota.ntt@gmail.com
  Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]
  In-Reply-To: <Yk/gq9osXcNDoFM2@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox