pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
Date: Mon, 18 Apr 2022 13:55:13 +0900
Message-ID: <YlzvMeOnn/u8Z8MH@paquier.xyz> (raw)
In-Reply-To: <YlT23IvsXkGuLzFi@paquier.xyz>
References: <E1mfuYK-0004Bn-7O@gemulon.postgresql.org>
	<3385143.1649353230@sss.pgh.pa.us>
	<20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de>
	<3386734.1649354265@sss.pgh.pa.us>
	<20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de>
	<4015413.1649454951@sss.pgh.pa.us>
	<20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de>
	<CA+hUKGJ-gvLg9vJgMvu62XW-Nsb2Hf40DvqmKdusVeJ7KV-crA@mail.gmail.com>
	<YlT23IvsXkGuLzFi@paquier.xyz>

On Tue, Apr 12, 2022 at 12:49:48PM +0900, Michael Paquier wrote:
> This comes from df86e52, where we want to recovery a history file that
> would be created as RECOVERYHISTORY and make sure that the file gets
> removed at the end of recovery.  So $standby2 should choose a new
> timeline different from the one of chosen by $standby.  Looking back
> at what has been done, it seems to me that the comment is the
> incorrect part:
> https://www.postgresql.org/message-id/20190930080340.GO2888@paquier.xyz

acf1dd42 has taken care of the failures of this test with skink, and I
have just taken care of the two races in the tests with e61efaf and
1a8b110.  I have left e61efaf out of REL_10_STABLE as the idea of
relying on a poll_query_until() with pg_stat_file() and an absolute
path would not work there, and the branch will be EOL'd soon while
there were no complains with this test for two years.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (20+ messages)  latest in thread

Message-ID: <YlzvMeOnn/u8Z8MH@paquier.xyz>
Permalink:  ../YlzvMeOnn%2Fu8Z8MH@paquier.xyz/
Also on:    postgresql.org/message-id/YlzvMeOnn/u8Z8MH@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, thomas.munro@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
  In-Reply-To: <YlzvMeOnn/u8Z8MH@paquier.xyz>
  References: <E1mfuYK-0004Bn-7O@gemulon.postgresql.org> <3385143.1649353230@sss.pgh.pa.us> <20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de> <3386734.1649354265@sss.pgh.pa.us> <20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de> <4015413.1649454951@sss.pgh.pa.us> <20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de> <CA+hUKGJ-gvLg9vJgMvu62XW-Nsb2Hf40DvqmKdusVeJ7KV-crA@mail.gmail.com> <YlT23IvsXkGuLzFi@paquier.xyz> <YlzvMeOnn/u8Z8MH@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox