pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Replace existing durable_rename_excl() calls with durable_rename
Date: Thu, 28 Apr 2022 12:48:27 +0900
Message-ID: <YmoOiy8BIbngwMBY@paquier.xyz> (raw)
In-Reply-To: <511362.1651116498@sss.pgh.pa.us>
References: <E1njsi7-001T1K-4n@gemulon.postgresql.org>
	<511362.1651116498@sss.pgh.pa.us>

On Wed, Apr 27, 2022 at 11:28:18PM -0400, Tom Lane wrote:
> Assert'ing that an external (filesystem) condition holds seems like a bad
> idea.  See buildfarm.

Yes, I saw the failures:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=kestrel&dt=2022-04-28%2002%3A13%3A27
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rorqual&dt=2022-04-28%2002%3A14%3A08
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=calliphoridae&dt=2022-04-28%2002%3A59%3A...

All of them are on 025_stuck_on_old_timeline.pl when the WAL receiver
writes a TLI history file when fetching it from a primary, meaning
that we need to think harder about this case as we would overwrite an
existing TLI file once we use durable_rename() over
durable_rename_excl().

I don't want to keep the buildfarm unstable, so I'll revert for now.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (3+ messages)

Message-ID: <YmoOiy8BIbngwMBY@paquier.xyz>
Permalink:  ../YmoOiy8BIbngwMBY@paquier.xyz/
Also on:    postgresql.org/message-id/YmoOiy8BIbngwMBY@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Replace existing durable_rename_excl() calls with durable_rename
  In-Reply-To: <YmoOiy8BIbngwMBY@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox