pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: andrew@dunslane.net
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Only allow returning string types or bytea from json_serialize
Date: Fri, 8 Jul 2022 19:20:14 +0900
Message-ID: <YsgE3g3NNLRCEMcH@paquier.xyz> (raw)
In-Reply-To: <20220708.154135.2123613118233840495.horikyota.ntt@gmail.com>
References: <E1o9ZK7-001hML-4h@gemulon.postgresql.org>
	<20220708.154135.2123613118233840495.horikyota.ntt@gmail.com>

On Fri, Jul 08, 2022 at 03:41:35PM +0900, Kyotaro Horiguchi wrote:
> I noticed that this introcues the following error message.
> 
> +  errmsg("cannot use RETURNING type %s in JSON_SERIALIZE"
> +								format_type_be(returning->typid)),
> 
> However, the same file has the following error message.
> 
> >			 errmsg("cannot use RETURNING type %s in %s",
> >					format_type_be(returning->typid), fname),
> 
> So, couldn't we share the format string to reduce translatable
> messages?

Yeah, I think that you are right, so let's fix this.  If Andrew does
not show up, I'll take care of it.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (6+ messages)  latest in thread

Message-ID: <YsgE3g3NNLRCEMcH@paquier.xyz>
Permalink:  ../YsgE3g3NNLRCEMcH@paquier.xyz/
Also on:    postgresql.org/message-id/YsgE3g3NNLRCEMcH@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, horikyota.ntt@gmail.com, andrew@dunslane.net
  Subject: Re: pgsql: Only allow returning string types or bytea from json_serialize
  In-Reply-To: <YsgE3g3NNLRCEMcH@paquier.xyz>
  References: <E1o9ZK7-001hML-4h@gemulon.postgresql.org> <20220708.154135.2123613118233840495.horikyota.ntt@gmail.com> <YsgE3g3NNLRCEMcH@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox