pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Christoph Berg <myon@debian.org>
To: Tomas Vondra <tomas.vondra@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
Date: Wed, 8 Mar 2023 18:55:03 +0100
Message-ID: <ZAjL96N9ZW84U59p@msg.df7cb.de> (raw)
In-Reply-To: <E1pVI5z-000MHR-Ch@gemulon.postgresql.org>
References: <E1pVI5z-000MHR-Ch@gemulon.postgresql.org>

Re: Tomas Vondra
> Add LZ4 compression to pg_dump

This broke the TAP tests on Ubuntu 18.04 (bionic):

[17:06:45.513](0.000s) ok 1927 - compression_lz4_custom: should not dump test_table with 4-row INSERTs
# Running: pg_dump --jobs=2 --format=directory --compress=lz4:1 --file=/home/myon/projects/postgresql/pg/master/build/src/bin/pg_dump/tmp_check/tmp_test__aAO/compression_lz4_dir postgres
[17:06:46.651](1.137s) ok 1928 - compression_lz4_dir: pg_dump runs
# Running: /usr/bin/lz4 -z -f --rm /home/myon/projects/postgresql/pg/master/build/src/bin/pg_dump/tmp_check/tmp_test__aAO/compression_lz4_dir/blobs.toc /home/myon/projects/postgresql/pg/master/build/src/bin/pg_dump/tmp_check/tmp_test__aAO/compression_lz4_dir/blobs.toc.lz4
Incorrect parameters
Usage :
      /usr/bin/lz4 [arg] [input] [output]

input   : a filename
          with no FILE, or when FILE is - or stdin, read standard input
Arguments :
 -1     : Fast compression (default) 
 -9     : High compression 
 -d     : decompression (default for .lz4 extension)
 -z     : force compression
 -f     : overwrite output without prompting 
 -h/-H  : display help/long help and exit
[17:06:46.667](0.016s) not ok 1929 - compression_lz4_dir: compression commands
[17:06:46.668](0.001s) 
[17:06:46.668](0.001s) #   Failed test 'compression_lz4_dir: compression commands'
[17:06:46.669](0.000s) #   at t/002_pg_dump.pl line 4274.
[17:06:46.670](0.001s) ok 1930 - compression_lz4_dir: glob check for /home/myon/projects/postgresql/pg/master/build/src/bin/pg_dump/tmp_check/tmp_test__aAO/compression_lz4_dir/toc.dat

The lz4 binary there doesn't have the --rm option yet.

liblz4-tool                      0.0~r131-2ubuntu3

--rm appears in a single place only:

                 # Give coverage for manually compressed blob.toc files during
                 # restore.
                 compress_cmd => {
                         program => $ENV{'LZ4'},
                         args    => [
                                 '-z', '-f', '--rm',
                                 "$tempdir/compression_lz4_dir/blobs.toc",
                                 "$tempdir/compression_lz4_dir/blobs.toc.lz4",
                         ],
                 },

18.04 will be EOL in a few weeks so it might be ok to just say it's
not supported, but removing the input file manually after calling lz4
would be an easy fix.

Christoph





view thread (10+ messages)  latest in thread

Message-ID: <ZAjL96N9ZW84U59p@msg.df7cb.de>
Permalink:  ../ZAjL96N9ZW84U59p@msg.df7cb.de/
Also on:    postgresql.org/message-id/ZAjL96N9ZW84U59p@msg.df7cb.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: myon@debian.org, tomas.vondra@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
  In-Reply-To: <ZAjL96N9ZW84U59p@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox