From: Daniel Gustafsson <daniel@yesql.se>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Christoph Berg <myon@debian.org>
Cc: Tomas Vondra <tomas.vondra@postgresql.org>
Cc: Jacob Champion <jchampion@timescale.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
Date: Thu, 6 Apr 2023 20:40:55 +0200
Message-ID: <367105C9-D199-4D0A-B3D4-B07113440065@yesql.se> (raw)
In-Reply-To: <ZC7101iyfVyYPJXd@telsasoft.com>
References: <E1pVI5z-000MHR-Ch@gemulon.postgresql.org>
<ZAjL96N9ZW84U59p@msg.df7cb.de>
<E6DD8AC9-3EE4-4E7B-A2BC-53FDF04D1ED0@yesql.se>
<819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com>
<ZAkol+4UyWuBR7PS@paquier.xyz>
<0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com>
<74f02417-d18a-71dd-a406-8af41cbeb6c4@enterprisedb.com>
<ZC7101iyfVyYPJXd@telsasoft.com>
> On 6 Apr 2023, at 18:39, Justin Pryzby <pryzby@telsasoft.com> wrote:
> *If* you wanted to do something to fix this, you could create a key
> called files_to_remove_after_loading, and run unlink on those files
> rather than running a shell command. Or maybe just remove the file
> unconditionally at the start of the script ?
Since the test is written in Perl, and Perl has a function for deleting files
which abstracts the platform differences, using it seems like a logical choice?
{cleanup_cmd} can be replaced with {cleanup_files} with an unlink called on
that?
--
Daniel Gustafsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, pryzby@telsasoft.com, tomas.vondra@enterprisedb.com, michael@paquier.xyz, myon@debian.org, tomas.vondra@postgresql.org, jchampion@timescale.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
In-Reply-To: <367105C9-D199-4D0A-B3D4-B07113440065@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox