From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alexander Korotkov <akorotkov@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Teach contrib/amcheck to check the unique constraint violation
Date: Mon, 30 Oct 2023 14:52:55 -0400
Message-ID: <ZT_7hyCRfhkAFI0b@momjian.us> (raw)
In-Reply-To: <ZT9YoDPEQBUMrIHg@paquier.xyz>
References: <E1qwUH8-002fDJ-Eq@gemulon.postgresql.org>
<ZT9YoDPEQBUMrIHg@paquier.xyz>
On Mon, Oct 30, 2023 at 04:17:52PM +0900, Michael Paquier wrote:
> Hi Alexander,
>
> On Fri, Oct 27, 2023 at 09:21:50PM +0000, Alexander Korotkov wrote:
> > Teach contrib/amcheck to check the unique constraint violation
> >
> > Add the 'checkunique' argument to bt_index_check() and bt_index_parent_check().
> > When the flag is specified the procedures will check the unique constraint
> > violation for unique indexes. Only one heap entry for all equal keys in
> > the index should be visible (including posting list entries). Report an error
> > otherwise.
> >
> > pg_amcheck called with the --checkunique option will do the same check for all
> > the indexes it checks.
>
> koel is unhappy with the indentation done in this commit. See the
> parts about verify_nbtree.c and pg_amcheck.c:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-10-30%2007%3A04%3A04
Thanks, ran pgindent fix commits de64268561 and 5ae2087202a.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: bruce@momjian.us, michael@paquier.xyz, akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Teach contrib/amcheck to check the unique constraint violation
In-Reply-To: <ZT_7hyCRfhkAFI0b@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox