pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Christoph Berg <myon@debian.org>
To: Thomas Munro <thomas.munro@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Don't trust unvalidated xl_tot_len.
Date: Sat, 11 Nov 2023 12:53:37 +0100
Message-ID: <ZU9rQYbAenlvgpsg@msg.df7cb.de> (raw)
In-Reply-To: <CA+hUKGLm3+2NZX1pEv+2Ky+MmD+nLeBxsNxKYtowepHUnbg8FQ@mail.gmail.com>
References: <E1qjozv-005NY4-Rr@gemulon.postgresql.org>
	<ZU5yKecW5yMKKhtp@msg.df7cb.de>
	<ZU6jwsm4XvmAUUTN@msg.df7cb.de>
	<CA+hUKGLm3+2NZX1pEv+2Ky+MmD+nLeBxsNxKYtowepHUnbg8FQ@mail.gmail.com>

Re: Thomas Munro
> In the 13 branch we see that's in the new scan_server_header()
> subroutine where it tries to open the header, after asking pg_config
> --includedir-server where it lives.  Hmm...

It's no ok to use pg_config at test time since `make install` might
not have been called yet:

https://www.postgresql.org/message-id/2023925.1644591595@sss.pgh.pa.us
https://www.postgresql.org/message-id/YqkV/hoi2SX91it8@paquier.xyz

Christoph

view thread (18+ messages)  latest in thread

Message-ID: <ZU9rQYbAenlvgpsg@msg.df7cb.de>
Permalink:  ../ZU9rQYbAenlvgpsg@msg.df7cb.de/
Also on:    postgresql.org/message-id/ZU9rQYbAenlvgpsg@msg.df7cb.de

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: myon@debian.org, thomas.munro@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Don't trust unvalidated xl_tot_len.
  In-Reply-To: <ZU9rQYbAenlvgpsg@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox